Exclude E_USER_DEPRECATED from error handler mask - #337
Merged
Conversation
E_DEPRECATED (8192) and E_USER_DEPRECATED (16384) are separate bits. Without excluding E_USER_DEPRECATED, trigger_error() calls from third-party libraries (e.g. symfony/deprecation-contracts) were caught by handleError() and thrown as ErrorException, causing HTTP 500 errors.
bbankowski
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ErrorHandler::register()used the maskE_ALL & ~E_DEPRECATED, which only excludesE_DEPRECATED(8192 — PHP engine deprecations).E_USER_DEPRECATED(16384) is a separate bit emitted by userland code viatrigger_error($msg, E_USER_DEPRECATED).Because
E_USER_DEPRECATEDfell through the mask,handleError()received it and threw anErrorException, turning a deprecation notice from third-party libraries (e.g.symfony/deprecation-contracts, used bymicrosoft/azure-storage-common) into a fatal HTTP 500 error.Fix
Added
& ~E_USER_DEPRECATEDto the error handler mask inErrorHandler::register().