Open
Conversation
This was referenced Apr 24, 2026
aarongable
previously approved these changes
Apr 24, 2026
aarongable
approved these changes
Apr 24, 2026
beautifulentropy
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The behaviour for
Get()was notably different thanSelectOne().Get()filtersErrNoRowsand returns anilobject instead.SelectOne()takes a successful result that returned no rows, and specifically returnssql.ErrNoRowsfor it.Consolidate on returning
ErrNoRows.Note that there are a number of other functions that share
Get()'s behavior of returning a default value onErrNoRows:I haven't touched these in this PR. They are mostly unused in Boulder, with the small exception of SelectNullInt. My plan is to remove all references to these from Boulder, then remove them from this repo.