Skip to content

feat(SUP-1503): add GBrain graph eval coverage#23

Merged
levineam merged 2 commits into
sup-1500-gbrain-graph-recallfrom
sup-1503-gbrain-graph-eval
May 10, 2026
Merged

feat(SUP-1503): add GBrain graph eval coverage#23
levineam merged 2 commits into
sup-1500-gbrain-graph-recallfrom
sup-1503-gbrain-graph-eval

Conversation

@levineam

Copy link
Copy Markdown
Owner

Summary

  • Add --compare-graph support to the @jarvos/gbrain retrieval eval harness.
  • Let eval questions declare graphSeeds, per-question graphDepth, and graph-specific expected evidence under expected.graph.
  • Report a separate gbrain_graph engine so graph sidecar success does not mask direct GBrain search misses.
  • Document graph sidecar eval usage and update the public template fixture.

Why

SUP-1499 showed direct GBrain search at 6/8 while QMD was 8/8. SUP-1500/PR #22 adds graph recall because the two GBrain misses are cross-source graph traversal questions. This PR turns that manual sidecar proof into eval coverage.

Private validation

Using the private eval fixture with graph seeds:

  • Direct GBrain search: 6/8
  • QMD: 8/8
  • gbrain_graph: 2/2 on the two cross-source misses

Private report: /Users/andrew/clawd/memory/projects/jarvos-gbrain/graph-eval-baseline-2026-05-10.md

Local validation

  • node --check modules/jarvos-gbrain/src/index.js && node --check modules/jarvos-gbrain/scripts/jarvos-gbrain.js
  • npm test --prefix modules/jarvos-gbrain
  • private eval with --compare-qmd --compare-graph --timeout-ms 15000
  • node tests/modules-smoke-test.js
  • bash scripts/smoke-test.sh
  • npm test
  • git diff --check

Stack

Base branch: sup-1500-gbrain-graph-recall / PR #22.

@coderabbitai

coderabbitai Bot commented May 10, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 3f3a0e71-9615-40d4-a219-99a8da2e74b2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sup-1503-gbrain-graph-eval

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@levineam
levineam marked this pull request as ready for review May 10, 2026 11:25

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ea358a21ec

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread modules/jarvos-gbrain/src/index.js Outdated

if (compareGraph && typeof entry === 'object') {
const graphSeeds = graphSeedsForEntry(entry);
if (graphSeeds.length > 0) {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Fail graph expectations that have no seeds

When --compare-graph is enabled and a question declares expected.graph/graphExpected but graphSeeds is omitted or misspelled, this guard silently skips adding the gbrain_graph engine. The question can still pass on the direct GBrain result, so the graph-sidecar expectation is never exercised and a misconfigured graph eval appears green; detect a graph expectation with no seeds and mark it failed instead of skipping it.

Useful? React with 👍 / 👎.

@levineam
levineam force-pushed the sup-1500-gbrain-graph-recall branch from 61c5f78 to 62a4a7a Compare May 10, 2026 12:14
@levineam
levineam force-pushed the sup-1503-gbrain-graph-eval branch 2 times, most recently from 3519e97 to dec2384 Compare May 10, 2026 12:22
@levineam
levineam force-pushed the sup-1500-gbrain-graph-recall branch from 6744ee9 to a9b677f Compare May 10, 2026 12:28
@levineam
levineam force-pushed the sup-1503-gbrain-graph-eval branch from dec2384 to e99c638 Compare May 10, 2026 12:28
@levineam
levineam force-pushed the sup-1503-gbrain-graph-eval branch from e99c638 to e7d61f4 Compare May 10, 2026 12:36
@levineam
levineam merged commit df6b6ed into sup-1500-gbrain-graph-recall May 10, 2026
6 checks passed
@levineam
levineam deleted the sup-1503-gbrain-graph-eval branch May 10, 2026 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant