feat(SUP-1503): add GBrain graph eval coverage#23
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea358a21ec
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| if (compareGraph && typeof entry === 'object') { | ||
| const graphSeeds = graphSeedsForEntry(entry); | ||
| if (graphSeeds.length > 0) { |
There was a problem hiding this comment.
Fail graph expectations that have no seeds
When --compare-graph is enabled and a question declares expected.graph/graphExpected but graphSeeds is omitted or misspelled, this guard silently skips adding the gbrain_graph engine. The question can still pass on the direct GBrain result, so the graph-sidecar expectation is never exercised and a misconfigured graph eval appears green; detect a graph expectation with no seeds and mark it failed instead of skipping it.
Useful? React with 👍 / 👎.
61c5f78 to
62a4a7a
Compare
3519e97 to
dec2384
Compare
6744ee9 to
a9b677f
Compare
dec2384 to
e99c638
Compare
e99c638 to
e7d61f4
Compare
Summary
--compare-graphsupport to the@jarvos/gbrainretrieval eval harness.graphSeeds, per-questiongraphDepth, and graph-specific expected evidence underexpected.graph.gbrain_graphengine so graph sidecar success does not mask direct GBrain search misses.Why
SUP-1499 showed direct GBrain search at 6/8 while QMD was 8/8. SUP-1500/PR #22 adds graph recall because the two GBrain misses are cross-source graph traversal questions. This PR turns that manual sidecar proof into eval coverage.
Private validation
Using the private eval fixture with graph seeds:
gbrain_graph: 2/2 on the two cross-source missesPrivate report:
/Users/andrew/clawd/memory/projects/jarvos-gbrain/graph-eval-baseline-2026-05-10.mdLocal validation
node --check modules/jarvos-gbrain/src/index.js && node --check modules/jarvos-gbrain/scripts/jarvos-gbrain.jsnpm test --prefix modules/jarvos-gbrain--compare-qmd --compare-graph --timeout-ms 15000node tests/modules-smoke-test.jsbash scripts/smoke-test.shnpm testgit diff --checkStack
Base branch:
sup-1500-gbrain-graph-recall/ PR #22.