Upgrade Arrow crates to v57.3.0 across workspace#97
Conversation
Updated arrow-array, arrow-schema, parquet, and related arrow crates from version 56.2.0 to 57.3.0. Removed deprecated num crate and replaced it with num-traits and related crates as dependencies. Also upgraded lz4_flex to 0.12.0. Updated Cargo.lock and Cargo.toml files in chutoro-cli and chutoro-providers/dense accordingly. Co-authored-by: devboxerhub[bot] <devboxerhub[bot]@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughReport workspace dependency declarations added for Changes
Sequence Diagram(s)(Skipped — changes are manifest-only and do not introduce new multi-component control flow.) Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related issues
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpgrades Arrow-related crates across the workspace to the 57.0.0 release line, updates parquet and a few compression/numeric dependencies for compatibility, and refreshes Cargo.lock accordingly, without introducing code-level behavior changes. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Since Arrow and Parquet versions are now shared across multiple crates, consider centralizing them in
[workspace.dependencies](or a shared[patch]/[workspace.package]section) to avoid version drift between crates in future upgrades.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since Arrow and Parquet versions are now shared across multiple crates, consider centralizing them in `[workspace.dependencies]` (or a shared `[patch]`/`[workspace.package]` section) to avoid version drift between crates in future upgrades.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@chutoro-cli/Cargo.toml`:
- Around line 27-29: The dev-dependencies list in this crate uses literal
versions for arrow-array, arrow-schema and parquet which can drift; change the
entries in this file's [dev-dependencies] so arrow-array and arrow-schema use {
workspace = true } and parquet uses { workspace = true, features = ["arrow"] }
to preserve its feature flag, and then add a single [workspace.dependencies]
table in the workspace root Cargo.toml declaring concrete versions for
arrow-array, arrow-schema and parquet (e.g. "57.0.0") so all leaf crates inherit
the versions from the workspace.
ℹ️ Review info
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lock
📒 Files selected for processing (2)
chutoro-cli/Cargo.tomlchutoro-providers/dense/Cargo.toml
- Added arrow-array, arrow-schema, and parquet as workspace dependencies in root Cargo.toml - Updated chutoro-cli and chutoro-providers/dense to reference these dependencies from the workspace - Enables consistent dependency management and version alignment across crates Co-authored-by: devboxerhub[bot] <devboxerhub[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Cargo.toml`:
- Around line 19-22: Update the pinned workspace dependencies for the Arrow
crates to the latest 57.x releases: change the versions under
[workspace.dependencies] for arrow-array, arrow-schema, and parquet from
"57.0.0" to "57.3.0" so the workspace uses arrow-array, arrow-schema, and
parquet = "57.3.0"; ensure you edit the entries named exactly "arrow-array",
"arrow-schema", and "parquet" in the Cargo.toml [workspace.dependencies] section
and commit the updated Cargo.toml.
Update workspace dependency pins for arrow-array, arrow-schema, and parquet from 57.0.0 to 57.3.0. This keeps workspace-level versions aligned with the current 57.x lockfile resolution while preserving centralized version management through [workspace.dependencies].
Summary
Changes
Workspace
chutoro-cli
chutoro-providers/dense
Testing
Notes
◳ Generated by DevBoxer ◰
ℹ️ Tag @devboxerhub to ask questions and address PR feedback
📎 Task: https://www.devboxer.com/task/5ad3f678-0c39-40ac-9867-31d079b16c46