docs: mark #125 FD-ownership hazard resolved in roadmap 8.1 (#125)

[leynos]

Summary

Roadmap Section 8.1 previously bundled issues #124 and #125 into a single outstanding "pump file-descriptor close race" work item. The #125 panic-unwind FD ownership hazard is now fixed in code and regression-tested, so this documentation-only change stops presenting it as outstanding implementation work.

Closes #125.

Changes

• Record #125 as resolved: with_borrowed_reader wraps the borrowed reader in ManuallyDrop, keeping a caller-owned reader FD open on both success and panic-unwind; pump_stream/consume_stream route through the helper; and rust/cuprum-rust/src/lib_tests.rs regression-tests that the borrowed FD survives normal and panicking operations.
• Rescope task 8.1.1 (the silent Bad file descriptor shutdown close race) to the still-outstanding #124.

Verification

make markdownlint and make nixie both pass (docs-only diff).

References

• Lody session: https://lody.ai/leynos/sessions/918b3e83-4ba3-4ac2-9374-04aeb9f0a186

🤖 Generated with Claude Code

Summary by Sourcery

Documentation:

• Clarify roadmap section 8.1 to mark issue Rust: extract FD-borrow RAII helper to centralise mem::forget ownership contract #125 as resolved, describe the implemented FD ownership safeguards and regression tests, and explicitly tie task 8.1.1 to issue Rust: fold split-first-iteration splice duplication into one loop; fix drain_reader EINTR handling #124.

[coderabbitai]

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

• @coderabbitai resume to resume automatic reviews.
• @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

• ▶️ Resume reviews
• 🔍 Trigger review

Walkthrough

Changes

Roadmap status update

Layer / File(s)	Summary
Record resolved FD ownership work docs/roadmap.md	Mark Phase 8.1 as resolved, document ManuallyDrop protection and helper routing, reference regression tests, and retain the shutdown Bad file descriptor fix in the checklist.

Suggested labels: Roadmap

Poem

Keep borrowed descriptors bright,
Through calm returns and panic flight.
Mark the ownership race as done,
Leave shutdown’s error for one.

🚥 Pre-merge checks | ✅ 18 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Developer Documentation	⚠️ Warning	Roadmap marks #125 resolved, but with_borrowed_reader/ManuallyDrop is not documented in docs/developers-guide.md or an ADR, and 8.1.1 remains unchecked.	Document the helper contract in docs/developers-guide.md and the relevant ADR/execplan, then check off the completed roadmap item while leaving 8.1.1 open.
Linked Issues check	❓ Inconclusive	The diff only updates roadmap documentation, so the linked code requirements cannot be verified from this PR alone.	Review the actual code changes for #125 and confirm the RAII helper, unwind safety, and regression tests are in place.

✅ Passed checks (18 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title matches the roadmap docs change and includes the linked issue reference.
Description check	✅ Passed	The description stays on-topic and accurately describes the roadmap update.
Out of Scope Changes check	✅ Passed	No unrelated changes appear beyond the roadmap status update and task rescope.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Testing (Overall)	✅ Passed	Docs-only diff; no new behaviour or tests introduced. Existing lib_tests.rs exercises real FD ownership on success and panic, and would catch close-on-unwind bugs.
User-Facing Documentation	✅ Passed	PASS: Treat this as docs-only; no user-facing behaviour changed, and docs/users-guide.md already covers the Rust stream backend.
Module-Level Documentation	✅ Passed	Only docs/roadmap.md changed; no modules were added or edited, so the module-docstring rule is not applicable here.
Testing (Unit And Behavioural)	✅ Passed	Treat the PR as passing: the regression tests cover both successful use and panic-unwind FD invariants, and this docs-only change needs no behavioural or E2E test.
Testing (Property / Proof)	✅ Passed	Docs-only roadmap update; no new invariant or proof obligation is introduced, and existing unwind regression tests already cover the FD-ownership hazard.
Testing (Compile-Time / Ui)	✅ Passed	Docs-only change; no compile-time/UI output was altered, and the crate already ships a trybuild compile-test harness.
Unit Architecture	✅ Passed	PASS: This is a docs-only roadmap update; only docs/roadmap.md changed, so no code paths, dependencies, or side-effect boundaries were altered.
Domain Architecture	✅ Passed	PASS: The PR is docs-only, touching docs/roadmap.md and not altering any domain, adapter, or infrastructure code or boundaries.
Observability	✅ Passed	Docs-only roadmap update; no operational behaviour, logging, metrics, tracing, or alerts were introduced or altered.
Security And Privacy	✅ Passed	Verify the diff: only docs/roadmap.md changed, and it only rewords roadmap status with issue refs and a helper summary; no secrets, auth, permissions, or data exposure added.
Performance And Resource Use	✅ Passed	Only docs/roadmap.md changed; no executable code, loops, allocations, I/O, or hot-path behaviour were introduced.
Concurrency And State	✅ Passed	PASS — keep this docs-only: the Rust helper already makes FD ownership explicit with unwind-safe ManuallyDrop and panic/success regression tests.
Architectural Complexity And Maintainability	✅ Passed	PASS: The PR is docs-only; it adds no new layers or dependencies, and the existing Rust helper/test setup already centralises the FD contract.
Rust Compiler Lint Integrity	✅ Passed	Only docs/roadmap.md changed; no Rust code, lint suppressions, or suspect clones were added, so compiler-lint integrity is unaffected.

📋 Issue Planner

Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).

View plan for ticket: #125

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch issue-125-rust-extract-fd-borrow-raii-helper-to-centralise-mem-forget-ownership-contract

---

_{Comment @coderabbitai help to get the list of available commands.}

[sourcery-ai]

Sorry @leynos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 49f363b521

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/roadmap.md`:
- Around line 458-460: Update the introductory roadmap description for step
8.1.1 to state that it targets or will remove the Rust pump shutdown failure,
matching the unchecked item and outstanding issue `#124`; do not describe the
failure as already removed.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 9c116b5c-264d-4723-996a-356377769327

📥 Commits

Reviewing files that changed from the base of the PR and between aa1fd32 and 49f363b.

📒 Files selected for processing (1)

• docs/roadmap.md

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

• leynos/shared-actions (auto-detected)
• leynos/pylint-pypy-shim (auto-detected)
• leynos/whitaker (auto-detected)

[buzzybee-df12]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[codescene-access]

No quality gates enabled for this code.