Skip to content

Enforce Oxford spelling with Typos - #385

Merged
leynos merged 2 commits into
mainfrom
typos-roll-out-focused
Jul 14, 2026
Merged

Enforce Oxford spelling with Typos#385
leynos merged 2 commits into
mainfrom
typos-roll-out-focused

Conversation

@leynos

@leynos leynos commented Jul 14, 2026

Copy link
Copy Markdown
Owner

Summary

  • generate the repository Typos policy from the shared estate dictionary
  • correct en-GB-oxendict spelling while preserving public protocol, workflow, fixture, migration, and serialized contracts
  • add pinned Typos, Nixie 1.1.0, and Merman 0.7.0 validation without changing the product build matrix
  • repair four existing Mermaid diagrams with semantics-preserving parser-compatible syntax

Validation

  • make check-fmt
  • make typecheck
  • make test: PostgreSQL 480, SQLite 484, wireframe-only 482, verification 69, and 5 doctests
  • make markdownlint
  • make nixie
  • make audit
  • Actionlint and mbake validate Makefile
  • helper tests: 3 passed with 95.45% coverage
  • exact census: 171 corrections across 58 paths; 96 legitimate protections across 34 paths
  • four private/test rename closures complete; public NewsDataFlavor and data_flavor preserved

Baseline findings

  • make lint retains five pre-existing Whitaker findings in unchanged src/presence_tests.rs
  • Checkmake retains the existing rust-audit body-length finding
  • exact-main Cargo.lock is stale under current manifests; Cargo-backed gates passed using the same ordinary resolution as hosted CI, and the unrelated generated lock delta is excluded from this PR

Generate the Typos policy from the shared estate dictionary and correct local spelling while preserving public protocol contracts. Add pinned Markdown and Mermaid validation, including minimal parser-compatible repairs for existing diagrams.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, your pull request is larger than the review limit of 150000 diff characters

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 20 minutes

Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d7f81ac2-a441-4ae5-9a2f-b00a30557fa1

📥 Commits

Reviewing files that changed from the base of the PR and between 33d384c and 47865d4.

📒 Files selected for processing (68)
  • .dockerignore
  • .github/workflows/ci.yml
  • .github/workflows/fuzz.yml
  • .gitignore
  • AGENTS.md
  • Makefile
  • docs/adopting-hexagonal-architecture-in-the-mxd-wireframe-migration.md
  • docs/complexity-antipatterns-and-refactoring-strategies.md
  • docs/design.md
  • docs/developers-guide.md
  • docs/execplans/1-2-4-model-handshake-readiness.md
  • docs/execplans/1-3-4-kani-harnesses-for-transaction-framing-invariants.md
  • docs/execplans/1-4-2-route-transactions-through-wireframe.md
  • docs/execplans/1-4-3-introduce-a-shared-session-context.md
  • docs/execplans/1-4-4-outbound-transport-and-messaging-traits.md
  • docs/execplans/1-4-5-reply-builder.md
  • docs/execplans/1-4-6-model-routed-transactions-and-session-gating.md
  • docs/execplans/1-5-1-detect-clients-that-xor-encode-text-fields.md
  • docs/execplans/1-5-2-gate-protocol-quirks-on-the-handshake-sub-version.md
  • docs/execplans/1-5-3-internal-compatibility-matrix.md
  • docs/execplans/1-5-4-verify-xor-and-sub-version-compatibility.md
  • docs/execplans/1-6-1-port-unit-and-integration-tests.md
  • docs/execplans/adopt-pg-embed-setup-v0-5-0.md
  • docs/execplans/adopt-rstest-bdd-v0-4-0.md
  • docs/execplans/adopt-rstest-bdd-v0-5-0.md
  • docs/execplans/wireframe-v0-3-0-migration.md
  • docs/file-sharing-design.md
  • docs/fuzzing.md
  • docs/migration-plan-moving-mxd-protocol-implementation-to-wireframe.md
  • docs/ortho-config-users-guide.md
  • docs/protocol.md
  • docs/reliable-testing-in-rust-via-dependency-injection.md
  • docs/roadmap.md
  • docs/rstest-bdd-users-guide.md
  • docs/rstest-bdd-v0-5-0-migration-guide.md
  • docs/rust-testing-with-rstest-fixtures.md
  • docs/wireframe-v0-2-0-to-v0-3-0-migration-guide.md
  • scripts/tests/test_typos_rollout_check.py
  • scripts/typos_rollout_check.py
  • src/commands/mod.rs
  • src/db/connection.rs
  • src/db/paths.rs
  • src/db/schema_alignment_tests/postgres_tests/threading.rs
  • src/db/tests/permission_tests.rs
  • src/db/tests/permission_tests_postgres.rs
  • src/field_id.rs
  • src/news_handlers/tests.rs
  • src/news_path.rs
  • src/server/admin.rs
  • src/server/legacy/mod.rs
  • src/server/wireframe/budgets.rs
  • src/transaction/frame.rs
  • src/transaction/params.rs
  • src/transaction/reader/streaming.rs
  • src/transaction/writer.rs
  • src/users.rs
  • src/wireframe/codec/mod.rs
  • src/wireframe/compat_policy_tests.rs
  • src/wireframe/message_assembly.rs
  • src/wireframe/route_ids.rs
  • src/wireframe/router_tests.rs
  • src/wireframe/routes/tests/routing_cases.rs
  • src/wireframe/test_helpers/mod.rs
  • test-util/src/server/mod.rs
  • tests/integration/admin_postgres.rs
  • tests/wireframe_xor_compat.rs
  • typos.local.toml
  • typos.toml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch typos-roll-out-focused

Comment @coderabbitai help to get the list of available commands.

codescene-access[bot]

This comment was marked as outdated.

codescene-access[bot]

This comment was marked as outdated.

@leynos
leynos marked this pull request as ready for review July 14, 2026 18:35
@leynos

leynos commented Jul 14, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/ci.yml:
- Line 15: Update the checkout step using actions/checkout to pin it to the
approved full commit SHA with its version comment, matching the other actions in
the job, and set persist-credentials to false because the job does not push
changes.

In `@docs/execplans/1-4-2-route-transactions-through-wireframe.md`:
- Line 462: Apply sentence case to the Artefacts and Notes heading in
docs/execplans/1-4-2-route-transactions-through-wireframe.md at lines 462-462,
docs/execplans/1-4-3-introduce-a-shared-session-context.md at lines 408-408, and
docs/execplans/1-4-4-outbound-transport-and-messaging-traits.md at lines 244-244
by changing Notes to notes.

In `@docs/ortho-config-users-guide.md`:
- Around line 433-437: Update the introductory sentence in the derive macro
configuration override documentation to insert a comma after “By default,” while
preserving the surrounding wording and behavior description.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: f7a75b43-c46a-48b8-a79e-48cb5eb212e3

📥 Commits

Reviewing files that changed from the base of the PR and between 33d384c and 6c78b8d.

📒 Files selected for processing (68)
  • .dockerignore
  • .github/workflows/ci.yml
  • .github/workflows/fuzz.yml
  • .gitignore
  • AGENTS.md
  • Makefile
  • docs/adopting-hexagonal-architecture-in-the-mxd-wireframe-migration.md
  • docs/complexity-antipatterns-and-refactoring-strategies.md
  • docs/design.md
  • docs/developers-guide.md
  • docs/execplans/1-2-4-model-handshake-readiness.md
  • docs/execplans/1-3-4-kani-harnesses-for-transaction-framing-invariants.md
  • docs/execplans/1-4-2-route-transactions-through-wireframe.md
  • docs/execplans/1-4-3-introduce-a-shared-session-context.md
  • docs/execplans/1-4-4-outbound-transport-and-messaging-traits.md
  • docs/execplans/1-4-5-reply-builder.md
  • docs/execplans/1-4-6-model-routed-transactions-and-session-gating.md
  • docs/execplans/1-5-1-detect-clients-that-xor-encode-text-fields.md
  • docs/execplans/1-5-2-gate-protocol-quirks-on-the-handshake-sub-version.md
  • docs/execplans/1-5-3-internal-compatibility-matrix.md
  • docs/execplans/1-5-4-verify-xor-and-sub-version-compatibility.md
  • docs/execplans/1-6-1-port-unit-and-integration-tests.md
  • docs/execplans/adopt-pg-embed-setup-v0-5-0.md
  • docs/execplans/adopt-rstest-bdd-v0-4-0.md
  • docs/execplans/adopt-rstest-bdd-v0-5-0.md
  • docs/execplans/wireframe-v0-3-0-migration.md
  • docs/file-sharing-design.md
  • docs/fuzzing.md
  • docs/migration-plan-moving-mxd-protocol-implementation-to-wireframe.md
  • docs/ortho-config-users-guide.md
  • docs/protocol.md
  • docs/reliable-testing-in-rust-via-dependency-injection.md
  • docs/roadmap.md
  • docs/rstest-bdd-users-guide.md
  • docs/rstest-bdd-v0-5-0-migration-guide.md
  • docs/rust-testing-with-rstest-fixtures.md
  • docs/wireframe-v0-2-0-to-v0-3-0-migration-guide.md
  • scripts/tests/test_typos_rollout_check.py
  • scripts/typos_rollout_check.py
  • src/commands/mod.rs
  • src/db/connection.rs
  • src/db/paths.rs
  • src/db/schema_alignment_tests/postgres_tests/threading.rs
  • src/db/tests/permission_tests.rs
  • src/db/tests/permission_tests_postgres.rs
  • src/field_id.rs
  • src/news_handlers/tests.rs
  • src/news_path.rs
  • src/server/admin.rs
  • src/server/legacy/mod.rs
  • src/server/wireframe/budgets.rs
  • src/transaction/frame.rs
  • src/transaction/params.rs
  • src/transaction/reader/streaming.rs
  • src/transaction/writer.rs
  • src/users.rs
  • src/wireframe/codec/mod.rs
  • src/wireframe/compat_policy_tests.rs
  • src/wireframe/message_assembly.rs
  • src/wireframe/route_ids.rs
  • src/wireframe/router_tests.rs
  • src/wireframe/routes/tests/routing_cases.rs
  • src/wireframe/test_helpers/mod.rs
  • test-util/src/server/mod.rs
  • tests/integration/admin_postgres.rs
  • tests/wireframe_xor_compat.rs
  • typos.local.toml
  • typos.toml

Comment thread .github/workflows/ci.yml Outdated
Comment thread docs/execplans/1-4-2-route-transactions-through-wireframe.md Outdated
Comment thread docs/ortho-config-users-guide.md
Pin the documentation checkout securely, improve touched documentation, and restore the approved helper-test assertion. Expand the compatibility-policy module documentation without changing its tested behaviour.
@leynos

leynos commented Jul 14, 2026

Copy link
Copy Markdown
Owner Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@codescene-access codescene-access Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gates Passed
6 Quality Gates Passed

See analysis details in CodeScene

Absence of Expected Change Pattern

  • mxd/src/wireframe/routes/tests/routing_cases.rs is usually changed with: mxd/src/wireframe/routes/tests/error_cases.rs, mxd/src/wireframe/routes/tests/helpers.rs

Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.

@codescene-access codescene-access Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No quality gates enabled for this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant