Enforce Oxford spelling with Typos - #385
Conversation
Generate the Typos policy from the shared estate dictionary and correct local spelling while preserving public protocol contracts. Add pinned Markdown and Mermaid validation, including minimal parser-compatible repairs for existing diagrams.
There was a problem hiding this comment.
Sorry @leynos, your pull request is larger than the review limit of 150000 diff characters
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 20 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (68)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 3
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Line 15: Update the checkout step using actions/checkout to pin it to the
approved full commit SHA with its version comment, matching the other actions in
the job, and set persist-credentials to false because the job does not push
changes.
In `@docs/execplans/1-4-2-route-transactions-through-wireframe.md`:
- Line 462: Apply sentence case to the Artefacts and Notes heading in
docs/execplans/1-4-2-route-transactions-through-wireframe.md at lines 462-462,
docs/execplans/1-4-3-introduce-a-shared-session-context.md at lines 408-408, and
docs/execplans/1-4-4-outbound-transport-and-messaging-traits.md at lines 244-244
by changing Notes to notes.
In `@docs/ortho-config-users-guide.md`:
- Around line 433-437: Update the introductory sentence in the derive macro
configuration override documentation to insert a comma after “By default,” while
preserving the surrounding wording and behavior description.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: f7a75b43-c46a-48b8-a79e-48cb5eb212e3
📒 Files selected for processing (68)
.dockerignore.github/workflows/ci.yml.github/workflows/fuzz.yml.gitignoreAGENTS.mdMakefiledocs/adopting-hexagonal-architecture-in-the-mxd-wireframe-migration.mddocs/complexity-antipatterns-and-refactoring-strategies.mddocs/design.mddocs/developers-guide.mddocs/execplans/1-2-4-model-handshake-readiness.mddocs/execplans/1-3-4-kani-harnesses-for-transaction-framing-invariants.mddocs/execplans/1-4-2-route-transactions-through-wireframe.mddocs/execplans/1-4-3-introduce-a-shared-session-context.mddocs/execplans/1-4-4-outbound-transport-and-messaging-traits.mddocs/execplans/1-4-5-reply-builder.mddocs/execplans/1-4-6-model-routed-transactions-and-session-gating.mddocs/execplans/1-5-1-detect-clients-that-xor-encode-text-fields.mddocs/execplans/1-5-2-gate-protocol-quirks-on-the-handshake-sub-version.mddocs/execplans/1-5-3-internal-compatibility-matrix.mddocs/execplans/1-5-4-verify-xor-and-sub-version-compatibility.mddocs/execplans/1-6-1-port-unit-and-integration-tests.mddocs/execplans/adopt-pg-embed-setup-v0-5-0.mddocs/execplans/adopt-rstest-bdd-v0-4-0.mddocs/execplans/adopt-rstest-bdd-v0-5-0.mddocs/execplans/wireframe-v0-3-0-migration.mddocs/file-sharing-design.mddocs/fuzzing.mddocs/migration-plan-moving-mxd-protocol-implementation-to-wireframe.mddocs/ortho-config-users-guide.mddocs/protocol.mddocs/reliable-testing-in-rust-via-dependency-injection.mddocs/roadmap.mddocs/rstest-bdd-users-guide.mddocs/rstest-bdd-v0-5-0-migration-guide.mddocs/rust-testing-with-rstest-fixtures.mddocs/wireframe-v0-2-0-to-v0-3-0-migration-guide.mdscripts/tests/test_typos_rollout_check.pyscripts/typos_rollout_check.pysrc/commands/mod.rssrc/db/connection.rssrc/db/paths.rssrc/db/schema_alignment_tests/postgres_tests/threading.rssrc/db/tests/permission_tests.rssrc/db/tests/permission_tests_postgres.rssrc/field_id.rssrc/news_handlers/tests.rssrc/news_path.rssrc/server/admin.rssrc/server/legacy/mod.rssrc/server/wireframe/budgets.rssrc/transaction/frame.rssrc/transaction/params.rssrc/transaction/reader/streaming.rssrc/transaction/writer.rssrc/users.rssrc/wireframe/codec/mod.rssrc/wireframe/compat_policy_tests.rssrc/wireframe/message_assembly.rssrc/wireframe/route_ids.rssrc/wireframe/router_tests.rssrc/wireframe/routes/tests/routing_cases.rssrc/wireframe/test_helpers/mod.rstest-util/src/server/mod.rstests/integration/admin_postgres.rstests/wireframe_xor_compat.rstypos.local.tomltypos.toml
Pin the documentation checkout securely, improve touched documentation, and restore the approved helper-test assertion. Expand the compatibility-policy module documentation without changing its tested behaviour.
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Gates Passed
6 Quality Gates Passed
See analysis details in CodeScene
Absence of Expected Change Pattern
- mxd/src/wireframe/routes/tests/routing_cases.rs is usually changed with: mxd/src/wireframe/routes/tests/error_cases.rs, mxd/src/wireframe/routes/tests/helpers.rs
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Summary
Validation
make check-fmtmake typecheckmake test: PostgreSQL 480, SQLite 484, wireframe-only 482, verification 69, and 5 doctestsmake markdownlintmake nixiemake auditmbake validate MakefileNewsDataFlavoranddata_flavorpreservedBaseline findings
make lintretains five pre-existing Whitaker findings in unchangedsrc/presence_tests.rsrust-auditbody-length findingCargo.lockis stale under current manifests; Cargo-backed gates passed using the same ordinary resolution as hosted CI, and the unrelated generated lock delta is excluded from this PR