-
Notifications
You must be signed in to change notification settings - Fork 0
Forward NEXTEST_TEST_JOBS to the dev-test target #671
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workinglowBacklog work, hygiene, or technical debt planned opportunistically, without a strict deadline.Backlog work, hygiene, or technical debt planned opportunistically, without a strict deadline.testingTest coverage, test infrastructure, and verification tooling work.Test coverage, test infrastructure, and verification tooling work.
Description
Activity
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinglowBacklog work, hygiene, or technical debt planned opportunistically, without a strict deadline.Backlog work, hygiene, or technical debt planned opportunistically, without a strict deadline.testingTest coverage, test infrastructure, and verification tooling work.Test coverage, test infrastructure, and verification tooling work.
make testhonoursNEXTEST_TEST_JOBS, andmake dev-testsilently drops it.test-nextestforwards both$(NEXTEST_BUILD_JOBS)and$(NEXTEST_TEST_JOBS)to
cargo nextest run.dev-test, the local accelerated runner, forwards only$(NEXTEST_BUILD_JOBS). Both targets invokecargo nextest run, so acontributor who sets
NEXTEST_TEST_JOBSsees it applied by one and ignored bythe other. Separating the build-worker bound from the test-worker bound exists
precisely to remove that surprise.
Raised by CodeRabbit while reviewing #664, which moved Linux CI to Ubicloud and
Windows and macOS to GitHub-hosted runners. It was deliberately left out of
that pull request:
dev-testis a local workflow that no CI lane exercises, sochanging it inside a runner migration would put an untested change behind a
green signal that never runs it. CodeRabbit agreed with that scoping and asked
for this follow-up.
Fix: forward
$(NEXTEST_TEST_JOBS)fromdev-testas well, and cover theagreement between the two targets in the Makefile contract tests so they cannot
drift again.