Conversation
Add a dedicated reference for every registered YAML and Jinja helper, including signatures, defaults, purity, platform caveats, and examples. Run the marked manifests through the real binary with isolated fixtures and stub executables. Keep the network example registry-gated without making a request, and replace the users' guide catalogue with links to the complete reference.
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughA dedicated standard-library guide now documents YAML/Jinja syntax and helper signatures. Documentation links and executable-example discovery were expanded, while registry and end-to-end tests cover filesystem, time, host, collection, and fetch-expression examples. ChangesStandard-library guide
Documentation integration
Executable-example validation
Sequence Diagram(s)sequenceDiagram
participant Guide as stdlib guide
participant Harness as documentation harness
participant Netsuke
participant Fixtures as test fixtures
Guide->>Harness: provide tested-example fences
Harness->>Netsuke: load registered manifests
Fixtures->>Netsuke: provide controlled files and host context
Netsuke->>Harness: generate documented outputs
Harness->>Harness: assert outputs and fetch registration
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 20✅ Passed checks (20 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Remove the leading space from the README link destination so GitHub renders the guide link correctly. Express the long `timedelta` signature in a form that remains within the documentation line-length limit after formatting.
Introduce Netsuke-focused YAML and Jinja guidance before the standard-library reference. Register both complete primer manifests so documentation drift or invalid syntax fails the existing example contracts.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f3a548d60e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/stdlib-yaml-and-jinja-guide.md`:
- Around line 54-57: Update the manifest control-key section around `foreach`
and `when` to state that they evaluate before typed AST deserialization, IR
generation, and Ninja execution. Clarify that direct build-time branching
applies to recipes unless runtime conditions are explicitly designed, while
preserving the existing syntax guidance.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 5f7749bf-5f24-4f18-b713-aaf5309f9996
📒 Files selected for processing (8)
README.mddocs/contents.mddocs/developers-guide.mddocs/stdlib-yaml-and-jinja-guide.mddocs/users-guide.mdtests/documentation_examples/mod.rstests/documentation_examples_e2e_tests.rstests/documentation_examples_tests.rs
🔗 Linked repositories identified
CodeRabbit considers these linked repositories for cross-repo context during reviews:
leynos/rstest-bdd(auto-detected)leynos/ortho-config(auto-detected)leynos/shared-actions(auto-detected)
Explain that shell and grep return a persisted temporary-file path in tempfile, stream, and streaming modes. Qualify realpath output so manifests do not assume relative inputs always produce relative paths.
State that `foreach` and `when` select entries before typed AST deserialization, IR generation, and Ninja execution. Direct users to recipes for build-time branching unless runtime conditions are explicitly modelled.
Summary
This branch adds brief Netsuke-focused YAML and Jinja syntax primers followed by a complete template standard-library reference, so readers can understand manifest structure before using every registered helper. Each helper has a concrete signature, defaults, purity classification, platform caveats, and copy-pasteable usage, while the documented examples remain executable contracts against the real Netsuke binary.
The guide distinguishes manifest-time control from build-time behaviour:
foreachandwhenselect entries before typed AST deserialization, IR generation, and Ninja execution, while direct build-time branching belongs in recipe commands or scripts unless runtime conditions are explicitly modelled. It also makes host-dependent return contracts explicit:realpathmay return an absolute path for relative input, whileshellandgrepreturn a persisted temporary-file path intempfile,stream, andstreamingmodes.Closes #443
Review walkthrough
Validation
make check-fmt: passedmake test: passedmake typecheck: passedmake lint: passedmake markdownlint: passedmake nixie: passedcoderabbit review --agent: passed with 0 findings on the final branchNotes
The registered
fetchexpression is checked for documentation and registry drift but deliberately not executed, so the documentation suite never makes a network request. All newly marked manifests compile through the real binary with deterministic local fixtures where required.References