Skip to content

Add empty string case for parse_blocks - #3

Merged
leynos merged 1 commit into
mainfrom
codex/test-parse_blocks-with-empty-string
Jun 9, 2025
Merged

Add empty string case for parse_blocks#3
leynos merged 1 commit into
mainfrom
codex/test-parse_blocks-with-empty-string

Conversation

@leynos

@leynos leynos commented Jun 8, 2025

Copy link
Copy Markdown
Owner

Summary

  • add a unit test for parse_blocks handling an empty string

Testing

  • pyright
  • ruff check
  • pytest -q

https://chatgpt.com/codex/tasks/task_e_68461fe1f51483228394613ad022e560

Summary by Sourcery

Tests:

  • Add test_parse_blocks_empty to assert parse_blocks("") returns an empty list.

@sourcery-ai

sourcery-ai Bot commented Jun 8, 2025

Copy link
Copy Markdown
Contributor

Reviewer's Guide

Introduces a new unit test to verify that parse_blocks returns an empty list when given an empty string.

File-Level Changes

Change Details Files
Added a unit test for empty string input in parse_blocks
  • Defined test_parse_blocks_empty()
  • Asserted parse_blocks("") == []
nixie/unittests/test_parse_blocks.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leynos - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@leynos
leynos merged commit 226071f into main Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant