Restore green CI: whitaker-installer 0.2.7 and generate-coverage ratchet fix - #147
Conversation
installer 0.2.5 provisions cargo-dylint 4.1.0, whose dylint driver cannot build on the suite's new nightly-2026-05-28 pin; 0.2.6 provisions cargo-dylint 6.0.1.
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 10 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
0.2.7 fixes the dylint-link install verification defect (leynos/whitaker#299) that made the lint gate fall back to an impossible source build.
The lint-test job's coverage ratchet false-tripped on a 0.07pp dip below a stale cached baseline (86.39% vs 86.46%), and the failure surfaced as a confusing empty-artefact-name upload error that masked it. Bump the `generate-coverage` and `upload-codescene-coverage` pins from 927edd45 to 1c1a46f0, which brings the ±1pp ratchet tolerance dead-band (leynos/shared-actions#353) that absorbs measurement jitter and the archive-masking fix (leynos/shared-actions#380) that surfaces a genuine ratchet failure instead of an empty-name error. The `setup-rust` pin is left unchanged.
Rebase onto main, which #147 already carried most of these workflow and action references to 1c1a46f0b4fde6dd78a9757fc475a5d06ee891c7. Only two references had not yet caught up: the dependabot-automerge reusable workflow and coverage-main's upload-codescene-coverage action, both still pinned to the older d3cbe87e commit. Bring both into line with the rest of the estate so every leynos/shared-actions reference in this repository resolves to the same commit.
Summary
This branch restores green CI for podbot, which was failing on two independent, unrelated causes. It applies the minimal fix for each.
1. Whitaker installer (
0.2.6→0.2.7)Installer 0.2.6 downloaded the correct, checksummed
dylint-link6.0.1 artefact but then executed it as a--helphealth check.dylint-linkis a linker wrapper with no reliable self-reporting subcommand, so the probe failed and verification fell back to a source build. Installer 0.2.7 (leynos/whitaker#299) trusts the verified repository artefact instead; the suite now installs from the release directly (confirmed in this branch's run: "Installed dylint-link from repository release").2. Coverage ratchet (
generate-coveragepin927edd45→1c1a46f0)Separately, the
lint-testjob's coverage ratchet false-tripped on a 0.07 percentage-point dip below a stale cached baseline (86.39% vs 86.46%), and that failure surfaced as a confusing "empty artifact name" upload error that masked it. Bumping thegenerate-coverageandupload-codescene-coveragepins brings the ±1pp ratchet tolerance dead-band (leynos/shared-actions#353), which absorbs measurement jitter, and the archive-masking fix (leynos/shared-actions#380), which surfaces a genuine ratchet failure instead of an empty-name error.Changes
WHITAKER_INSTALLER_VERSIONfrom0.2.6to0.2.7in .github/workflows/ci.yml.generate-coverageandupload-codescene-coveragepins from927edd45to1c1a46f0inci.ymlandcoverage-main.yml. Thesetup-rustpin is unchanged.Validation
dylint-linkfrom the repository release, and the coverage ratchet passes within the dead-band.Notes
No Rust toolchain pin is changed and the Whitaker lint gate is not weakened.