Skip to content

Restore green CI: whitaker-installer 0.2.7 and generate-coverage ratchet fix - #147

Merged
leynos merged 3 commits into
mainfrom
bump-whitaker-installer-0.2.6
Jul 23, 2026
Merged

Restore green CI: whitaker-installer 0.2.7 and generate-coverage ratchet fix#147
leynos merged 3 commits into
mainfrom
bump-whitaker-installer-0.2.6

Conversation

@leynos

@leynos leynos commented Jul 17, 2026

Copy link
Copy Markdown
Owner

Summary

This branch restores green CI for podbot, which was failing on two independent, unrelated causes. It applies the minimal fix for each.

1. Whitaker installer (0.2.60.2.7)

Installer 0.2.6 downloaded the correct, checksummed dylint-link 6.0.1 artefact but then executed it as a --help health check. dylint-link is a linker wrapper with no reliable self-reporting subcommand, so the probe failed and verification fell back to a source build. Installer 0.2.7 (leynos/whitaker#299) trusts the verified repository artefact instead; the suite now installs from the release directly (confirmed in this branch's run: "Installed dylint-link from repository release").

2. Coverage ratchet (generate-coverage pin 927edd451c1a46f0)

Separately, the lint-test job's coverage ratchet false-tripped on a 0.07 percentage-point dip below a stale cached baseline (86.39% vs 86.46%), and that failure surfaced as a confusing "empty artifact name" upload error that masked it. Bumping the generate-coverage and upload-codescene-coverage pins brings the ±1pp ratchet tolerance dead-band (leynos/shared-actions#353), which absorbs measurement jitter, and the archive-masking fix (leynos/shared-actions#380), which surfaces a genuine ratchet failure instead of an empty-name error.

Changes

  • Set WHITAKER_INSTALLER_VERSION from 0.2.6 to 0.2.7 in .github/workflows/ci.yml.
  • Bump the generate-coverage and upload-codescene-coverage pins from 927edd45 to 1c1a46f0 in ci.yml and coverage-main.yml. The setup-rust pin is unchanged.

Validation

  • CI on this PR exercises both paths: the Whitaker install now provisions dylint-link from the repository release, and the coverage ratchet passes within the dead-band.

Notes

No Rust toolchain pin is changed and the Whitaker lint gate is not weakened.

installer 0.2.5 provisions cargo-dylint 4.1.0, whose dylint driver cannot
build on the suite's new nightly-2026-05-28 pin; 0.2.6 provisions
cargo-dylint 6.0.1.

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @leynos, you have reached your weekly rate limit of 500000 diff characters.

Please try again later or upgrade to continue using Sourcery

@leynos
leynos enabled auto-merge (squash) July 17, 2026 20:05
@coderabbitai

coderabbitai Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 10 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 49211a42-9b58-4f5d-8cce-d7c9c8d8a0a2

📥 Commits

Reviewing files that changed from the base of the PR and between a337fc5 and 72fb2e7.

📒 Files selected for processing (2)
  • .github/workflows/ci.yml
  • .github/workflows/coverage-main.yml
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-whitaker-installer-0.2.6

Comment @coderabbitai help to get the list of available commands.

codescene-access[bot]

This comment was marked as outdated.

0.2.7 fixes the dylint-link install verification defect (leynos/whitaker#299)
that made the lint gate fall back to an impossible source build.
codescene-access[bot]

This comment was marked as outdated.

The lint-test job's coverage ratchet false-tripped on a 0.07pp dip below a
stale cached baseline (86.39% vs 86.46%), and the failure surfaced as a
confusing empty-artefact-name upload error that masked it. Bump the
`generate-coverage` and `upload-codescene-coverage` pins from 927edd45 to
1c1a46f0, which brings the ±1pp ratchet tolerance dead-band
(leynos/shared-actions#353) that absorbs measurement jitter and the
archive-masking fix (leynos/shared-actions#380) that surfaces a genuine
ratchet failure instead of an empty-name error.

The `setup-rust` pin is left unchanged.
@leynos leynos changed the title Bump whitaker-installer to 0.2.6 Restore green CI: whitaker-installer 0.2.7 and generate-coverage ratchet fix Jul 22, 2026
codescene-access[bot]

This comment was marked as outdated.

@codescene-access codescene-access Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No quality gates enabled for this code.

@leynos
leynos merged commit f916c47 into main Jul 23, 2026
7 checks passed
@leynos
leynos deleted the bump-whitaker-installer-0.2.6 branch July 23, 2026 00:00
leynos pushed a commit that referenced this pull request Jul 24, 2026
Rebase onto main, which #147 already carried most of these workflow
and action references to 1c1a46f0b4fde6dd78a9757fc475a5d06ee891c7.
Only two references had not yet caught up: the dependabot-automerge
reusable workflow and coverage-main's upload-codescene-coverage
action, both still pinned to the older d3cbe87e commit. Bring both
into line with the rest of the estate so every leynos/shared-actions
reference in this repository resolves to the same commit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant