Skip to content

Moving device model check to outside of Go code#1234

Merged
rvs merged 1 commit intolf-edge:masterfrom
rvs:bug
Jul 28, 2020
Merged

Moving device model check to outside of Go code#1234
rvs merged 1 commit intolf-edge:masterfrom
rvs:bug

Conversation

@rvs
Copy link
Contributor

@rvs rvs commented Jul 28, 2020

This is something I've been meaning to do for quite some time (since the way device model check is currently implemented has been incorrect for quite some time). However, at the same time this is NOT a final form of this change.

At the same time -- since this is a bit of an emergency fix -- I apologize for rushing it through.

The salient points here are:

  1. the check from Go code is gone for good -- it doesn't belong there (see below on where it belongs)
  2. the script xen-info is a quick hack (and that is the part I need to apologize for) but it is going to get removed by the end of this week with a proper fix

So what IS a proper fix -- well, something similar to Kubernetes container liveness checks -- something that would apply equally to VM-based containers and baremetal containers alike. I'll start a thread on eve-tsc@ today to discuss a few strategies there.

Signed-off-by: Roman Shaposhnik <rvs@zededa.com>
@rvs rvs merged commit 3d7221d into lf-edge:master Jul 28, 2020
for i in 1 2 3; do
ID=$(echo $(($(xl domid "$1") + 0))) ||:
ID=$(xl domid "$1" 2>/dev/null)
sleep 8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvs Don't understand why the old code did the sleep before the test/break. Do we need that 8 second delay?

@christoph-zededa christoph-zededa mentioned this pull request Jun 24, 2025
7 tasks
@rucoder rucoder mentioned this pull request Jul 4, 2025
This was referenced Nov 11, 2025
@eriknordmark eriknordmark mentioned this pull request Nov 25, 2025
9 tasks
@milan-zededa milan-zededa mentioned this pull request Feb 24, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants