Moving device model check to outside of Go code#1234
Merged
rvs merged 1 commit intolf-edge:masterfrom Jul 28, 2020
Merged
Conversation
Signed-off-by: Roman Shaposhnik <rvs@zededa.com>
| for i in 1 2 3; do | ||
| ID=$(echo $(($(xl domid "$1") + 0))) ||: | ||
| ID=$(xl domid "$1" 2>/dev/null) | ||
| sleep 8 |
Contributor
There was a problem hiding this comment.
@rvs Don't understand why the old code did the sleep before the test/break. Do we need that 8 second delay?
9 tasks
6 tasks
7 tasks
9 tasks
This was referenced Jun 25, 2025
9 tasks
7 tasks
This was referenced Jul 2, 2025
Merged
Closed
Closed
Merged
Merged
Closed
Merged
Merged
Merged
Merged
Closed
This was referenced Oct 6, 2025
9 tasks
7 tasks
9 tasks
9 tasks
9 tasks
This was referenced Nov 26, 2025
Merged
6 tasks
7 tasks
9 tasks
7 tasks
This was referenced Jan 5, 2026
9 tasks
This was referenced Jan 29, 2026
7 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is something I've been meaning to do for quite some time (since the way device model check is currently implemented has been incorrect for quite some time). However, at the same time this is NOT a final form of this change.
At the same time -- since this is a bit of an emergency fix -- I apologize for rushing it through.
The salient points here are:
So what IS a proper fix -- well, something similar to Kubernetes container liveness checks -- something that would apply equally to VM-based containers and baremetal containers alike. I'll start a thread on eve-tsc@ today to discuss a few strategies there.