Upgrade Lean toolchain to 4.24#2193
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Th0rgal
marked this pull request as ready for review
July 13, 2026 13:29
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_18f13345-858f-40f6-afdd-44fc20b58505) |
Contributor
There was a problem hiding this comment.
OpenCodeReview first-pass review
Status: no-supported · Mode: no-supported · 0 finding(s) · 0 files · 0 tokens · 0 tool calls
No changed files matched OCR include rules.
OCR pilot metrics
- Routing: no-supported (router-v8)
- Changed files: 0 supported / 0 total; Lean 0, trust docs 0, workflow/scripts 0, contracts 0, docs 0
- Changed lines: 0 supported; thresholds large Lean >=3 files or >800 lines
- OCR: status no-supported; comments 0; files 0; tokens 0; tool calls 0; warnings 0; duration 0s
Pilot mode: advisory only. Codex Review remains the merge gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dependency
This PR is stacked on and must land after:
The exact EVMYul commit pinned here is
38d53df8b4488d5322894619ea8385fcbb2e6f5d.Lean 4.24 trust delta
Lean 4.24 makes the recursive worker used by
String.startsWithprivate and exposes no publicsubstrEq/startsWithcorrectness theorem. Two closed identifier facts therefore usenative_decide, isolated inCompiler/CompilationModel/ReservedScratchNames.lean:Compiler.CompilationModel.compatScratch_startsWith_reservedCompiler.CompilationModel.compatScratch_not_internalImmutableThe generated
#print axiomsterms recordLean.ofReduceBool; native reduction also implicitly trusts Lean native code generation (Lean.trustCompiler), although that name is not present in the current printed proof terms.AXIOMS.mdandTRUST_ASSUMPTIONS.mddocument this distinction. CI pins exactly two native facts in that named module, rejects relocation/duplication, and keepsnative_decideout of non-testCompiler/Proofs.This adds no project axiom,
sorry, theorem weakening, or global heartbeat increase. The boundary is marked for removal once Lean or Batteries publishes the missing correctness lemmas.Validation
lake build— 2124 jobslake build PrintAxioms— 2421 jobsmake check— all checks; 612 Python tests, 1 expected skip; 0sorry; 0native_decidein non-test proofsmake test-evmyullean-fork— full fork conformance probe passedpython3 scripts/check_split_package_builds.py— all 3 split packagesgit diff --checkThis remains a draft until the EVMYul dependency lands and downstream benchmark/lean-lsp-mcp smoke validation is complete.
Note
Medium Risk
A full-toolchain bump plus a new documented
native_decidetrust boundary touches the entire proof build, though semantics and project axiom count are unchanged and CI gates the string facts.Overview
Upgrades Verity and split packages from Lean 4.22 to 4.24, pins Mathlib and EVMYulLean at
38d53df8…, and refreshes verification status, fork-audit, and generatedPrintAxiomsartifacts.Lean 4.24 string API gap: two compat scratch-name facts move from a large structural proof in
Storage.leanintoCompiler/CompilationModel/ReservedScratchNames.leanas isolatednative_decidelemmas, withAXIOMS.md/TRUST_ASSUMPTIONS.mdand CI (check_trust_surface_registry.py,check_axioms.pytreatingLean.trustCompiler) documenting and pinning that boundary—still zero project axioms.Proof maintenance for 4.24: per-op
lookupRuntimePrimOp_*rfl lemmas replace heavysimpon the full matcher (heartbeat); widespread proof call sites switch to those lemmas; Yul lowering proofs gain smaller helper lemmas; IR return-path proofs factorexecIRStmts_mstore_zero_return_32; Mathlib import/API fixes (abs_add_le, etc.).Misc:
internalFunctionYulNamehead-character lemmas consolidate builtin-name disequality proofs; minor string/simpcleanups in end-to-end and intrinsic error-message proofs.Reviewed by Cursor Bugbot for commit e271e12. Bugbot is set up for automated code reviews on this repo. Configure here.