Refactor: Call the shared release workflow - #13
Conversation
There was a problem hiding this comment.
🟡 Human review recommended
It changes the repository’s release publication path and tightens gating via an external reusable workflow, which warrants a final human check before relying on it for releases.
Pull request overview
Refactors the repository’s tag-driven release automation by replacing the previously duplicated “validate then promote” job graph with a thin caller that delegates to the organization’s shared reusable release workflow in lfreleng-actions/generic-workflows (pinned to b80a5a8…, v0.0.3). This centralizes release gating and promotion behavior and aligns this repo with the org-wide default release policy.
Changes:
- Replaced the in-repo “fat” tag-push workflow implementation with a reusable-workflow call.
- Renamed the workflow file from
tag-push.yamltorelease.yamlwhile keeping tag-push triggering and concurrency serialization.
File summaries
| File | Description |
|---|---|
| .github/workflows/tag-push.yaml | Removes the duplicated validate/publish implementation previously maintained locally. |
| .github/workflows/release.yaml | Adds a thin tag-push caller that invokes the shared reusable release workflow pinned to v0.0.3. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
The tag-push.yaml here duplicated a validate-then-promote job graph that almost a hundred repositories each carried their own copy of. Replace it with a caller that delegates to the release reusable in generic-workflows, pinned to v0.0.3. Rename the file to release.yaml. The name describes the outcome rather than the trigger, and sits beside the release-drafter.yaml that creates the draft this workflow publishes. The caller passes no inputs, so it adopts the organisation's default gating policy in full. Where a repository enforced only the versioning scheme, signature and pre-release checks, that adds four gates: enforce_increment, require_branch (default branch), require_recent (three minutes) and require_latest. Tags that are stale, raised off the default branch, or not at its tip now fail instead of producing a faulty immutable release. Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Matthew Watkins <mwatkins@linuxfoundation.org>
6146ccd to
dd3e2cb
Compare
There was a problem hiding this comment.
🟡 Not ready to approve
The pinned generic-workflows version used in code (v0.0.4) does not match the PR description (v0.0.3), which must be aligned for an accurate review of the adopted behavior/gates.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
This review doesn't count toward merge requirements. Sign up for the private preview to control whether Copilot approvals count.
Review details
Suppressed comments (1)
.github/workflows/release.yaml:45
- The PR description says this workflow is pinned to generic-workflows v0.0.3 (commit b80a5a8374fa54986ec542617efaa35e93515af6), but the caller actually uses commit 007258a132e4ba5358a20a5c0a902fa04de3a045 (v0.0.4). This mismatch makes it hard to review the exact gate set/behavior being adopted—please align the PR description and the pinned ref (either update the description to v0.0.4 or pin the workflow back to v0.0.3).
uses: lfreleng-actions/generic-workflows/.github/workflows/release.yaml@007258a132e4ba5358a20a5c0a902fa04de3a045 # v0.0.4
- Files reviewed: 2/2 changed files
- Comments generated: 0 new
- Review effort level: Lite
We're testing this review assessment. Please use 👍 or 👎 to tell us if it's correct.
tykeal
left a comment
There was a problem hiding this comment.
🤖 Dependamerge
Approved this pull request ✅
Why
tag-push.yamlhere duplicated a validate-then-promote job graph that 96repositories each carried their own copy of. This replaces it with a thin
caller delegating to the
release reusable in
generic-workflows,pinned to
v0.0.4
(
007258a132e4ba5358a20a5c0a902fa04de3a045).Renamed to
release.yamlThe name describes the outcome rather than the trigger, and sits beside the
release-drafter.yamlthat creates the draft this workflow publishes.Behaviour changes to be aware of
The caller passes no inputs, so it adopts the reusable's defaults in full —
the release-gating policy and the runner-hardening defaults.
1. Gating. Repositories that enforced only the versioning scheme, signature
and pre-release checks gain four gates:
enforce_incrementrequire_branchrequire_recentrequire_latestTags that are stale, raised off the default branch, or not at its tip now fail
rather than produce a faulty immutable release. This is the intended
organisation-wide default; it had simply not been rolled out everywhere. Eight
repositories already carried all eight gates — for those, nothing tightens.
2. Runner hardening. 14 repositories still ran harden-runner in
auditmode and move to
block. Every one of those 14 also lacks theharden-runner-block-actionallow-list loader, while all 82 onblockhaveit — they are stragglers on an older template, not deliberate opt-outs. After
this conversion all 96 run an identical workflow, so the egress profile is
uniform and already proven by the 82 running these exact steps under
block.3. Concurrency. Six repositories used a global group
(
${{ github.workflow }}), serialising all releases; they move to theestate-standard per-tag group (
${{ github.workflow }}-${{ github.ref }}).Distinct tags are independent work, and the reusable serialises itself per-tag
as well.
mark_latestdefaults totrue, matching thelatest: truethe old promotestep passed.
Tag deletions
Deleting a tag also fires this
pushevent. The reusable already guards itsown jobs with
if: ${{ !github.event.deleted }}, but the caller carries theguard too so that — exactly as before — no run starts at all.
Validation
The reusable and this caller pattern were exercised end-to-end in
test-release-process,the repository built to test the organisation's release tooling: a signed tag
push validated against the full gate set and promoted its draft release. This
generated caller passes
actionlintandyamllintagainst this repository'sown configuration.
Review note
The caller keeps its own
concurrencyblock. That is safe: the reusableserialises under
generic-workflows-release-${{ github.ref }}, a literalprefix that cannot collide with the caller's own group.
timeout-minutesis deliberately absent — GitHub does not permit it on a jobthat calls a reusable workflow (
actionlintrejects it). The reusable sets itsown timeouts of 2, 5 and 5 minutes on its three jobs.