fix bug with remote jobs for an op that takes a ConfigSet as its input #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as its basic input, rather than an Atoms object
bernstei
force-pushed
the
remote_op_with_configset_input
branch
from
ac915d0 to
bdbd700
Compare
bernstei
force-pushed
the
remote_op_with_configset_input
branch
2 times, most recently
from
f1c20ad to
f3e1eec
Compare
Contributor
Author
|
Looks like pwscf on these containers is broken, but since the tests pass on my machine, I'm going to merge if that's the only failure, and I'll open a different issue for fixing pw.x. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix very subtle bug in remote jobs with an op that takes a
ConfigSetas its basic input, rather than anAtomsobject.The subtlety of this bug feels like a bad sign for the overall design, but the tiny fix suggests maybe it's OK
closes #349