Add RBParameters::set_n_steps() and update RBTheta::evaluate() APIs#3571
Merged
jwpeterson merged 3 commits intolibMesh:develfrom Jun 1, 2023
Merged
Add RBParameters::set_n_steps() and update RBTheta::evaluate() APIs#3571jwpeterson merged 3 commits intolibMesh:develfrom
jwpeterson merged 3 commits intolibMesh:develfrom
Conversation
Previously, we determined the number of steps stored on an RBParameters object "dynamically" by simply checking how many steps the user had stored for the first (alphabetically) parameter. Unfortunately, this does not work well for a common use case, which is when there are no parameters actually stored on the RBParameters object, but it is still being used to represent multiple steps. In this case, the number of steps which the RBParameters object represents is returned by the n_steps() API.
…ti-step RBParameters object
dknez
approved these changes
May 31, 2023
|
Job Coverage on c780d04 wanted to post the following: Coverage
Warnings
This comment will be updated on new commits. |
||||||||||||||||||||||||||
|
Job Test MOOSE on c780d04 : invalidated by @jwpeterson Got "fatal error: CombinedRevision.h: No such file or directory" error again |
jwpeterson
added a commit
to jwpeterson/libmesh
that referenced
this pull request
Jun 2, 2023
The fix in libMesh#3571 makes this check unnecessary, since RBParameters objects with no parameters report having one step now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We often use
RBParametersobjects to "represent" multiple steps even when there are no parameters actually defined on theRBParametersobject. In this case, we just need the associatedRBThetaobjects to know that they should returnn_steps()copies of a value rather than a single copy. TheRBParameters::set_n_steps()API allows us to declare that anRBParametersobject has a certain number of steps in cases where there are no parameters.