A few more minor improvements for multi-step RBParameters objects#3575
Merged
jwpeterson merged 2 commits intolibMesh:develfrom Jun 2, 2023
Merged
A few more minor improvements for multi-step RBParameters objects#3575jwpeterson merged 2 commits intolibMesh:develfrom
jwpeterson merged 2 commits intolibMesh:develfrom
Conversation
The fix in libMesh#3571 makes this check unnecessary, since RBParameters objects with no parameters report having one step now.
Now that we have the possibility of multi-step RBParameters objects, the advice given in the previous deprecation message is no longer accurate, since it is not efficient to iterate over hundreds (or possibly thousands) of steps just to get the list of parameter names.
dknez
approved these changes
Jun 2, 2023
Member
Author
|
This is the second time in recent testing that I've seen: fail in debug mode. I don't think it's related to this PR but @roystgnr or @lindsayad might want to have a closer look at that one. |
Member
|
That failure was BCID data out of sync between processors. Definitely unrelated to this PR, and definitely concerning. I'm seeing if I can replicate it. |
Member
|
Well, that wasn't too hard. Running |
Member
Author
|
75% of the time, it works every time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RBParameters::get_parameter_names()APIs