Stitching debugging#3577
Merged
roystgnr merged 4 commits intolibMesh:develfrom Jun 8, 2023
Merged
Conversation
This turned out to be a red herring but it's a good idea in general.
This generally means an error happened earlier, but that still shouldn't lead to a segfault rather than a clean error message.
lindsayad
approved these changes
Jun 8, 2023
| libMesh::out << "In UnstructuredMesh::stitch_meshes:\n" | ||
| << "This mesh has " << this_boundary_node_ids.size() | ||
| << " nodes on boundary " << this_mesh_boundary_id << ".\n" | ||
| << " nodes on boundary `" |
Member
There was a problem hiding this comment.
Is using a backtick for the opening apostrophe standard practice?
Member
Author
There was a problem hiding this comment.
It's common; not sure if I'd call it standard. I probably picked it up from some system where it was actually a necessary way of clarifying nested quotations-within-quotations, and it's overkill here, but I don't think it's hurting anything.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't end up finding any functionality errors on the libMesh side of things, but there was an error in and some room to improve our console output, plus a few places where we should double-check for errors elsewhere.