Skip to content

Stitching debugging #3577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roystgnr merged 4 commits into from
Jun 8, 2023
Merged

Stitching debugging #3577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
59d3ccc
Fix parallel bounding box union in get_info()
roystgnr Jun 7, 2023
c256d23
Assert valid neighbors before stitching
roystgnr Jun 8, 2023
399dc5f
Print sideset names when verbose stitching
roystgnr Jun 8, 2023
72ccc4c
Error if asked to triangulate an empty mesh
roystgnr Jun 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/mesh/mesh_base.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1159,7 +1159,7 @@ std::string MeshBase::get_info(const unsigned int verbosity /* = 0 */, const boo
if (verbosity > 1)
{
this->comm().min(info.bbox.min());
this->comm().min(info.bbox.max());
this->comm().max(info.bbox.max());
}
}

Expand Down
5 changes: 4 additions & 1 deletion src/mesh/poly2tri_triangulator.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -292,9 +292,12 @@ void Poly2TriTriangulator::triangulate_current_points()
std::vector<p2t::Point> outer_boundary_points;
std::vector<std::vector<p2t::Point>> inner_hole_points(n_holes);

dof_id_type nn = _mesh.max_node_id();
libmesh_error_msg_if
(!nn, "Poly2TriTriangulator cannot triangulate an empty mesh!");

// Unless we're using an explicit segments list, we assume node ids
// are contiguous here.
dof_id_type nn = _mesh.max_node_id();
if (this->segments.empty())
libmesh_error_msg_if
(_mesh.n_nodes() != nn,
Expand Down
13 changes: 11 additions & 2 deletions src/mesh/unstructured_mesh.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1773,6 +1773,11 @@ void UnstructuredMesh::stitching_helper (const MeshBase * other_mesh,
bool enforce_all_nodes_match_on_boundaries,
bool skip_find_neighbors)
{
#ifdef DEBUG
// We rely on neighbor links here
MeshTools::libmesh_assert_valid_neighbors(*this);
#endif

// FIXME: make distributed mesh support efficient.
// Yes, we currently suck.
MeshSerializer serialize(*this);
Expand Down Expand Up @@ -1935,9 +1940,13 @@ void UnstructuredMesh::stitching_helper (const MeshBase * other_mesh,
{
libMesh::out << "In UnstructuredMesh::stitch_meshes:\n"
<< "This mesh has " << this_boundary_node_ids.size()
<< " nodes on boundary " << this_mesh_boundary_id << ".\n"
<< " nodes on boundary `"
Copy link
Copy Markdown
Member

@lindsayad lindsayad Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is using a backtick for the opening apostrophe standard practice?

Copy link
Copy Markdown
Member Author

@roystgnr roystgnr Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's common; not sure if I'd call it standard. I probably picked it up from some system where it was actually a necessary way of clarifying nested quotations-within-quotations, and it's overkill here, but I don't think it's hurting anything.

<< this->get_boundary_info().get_sideset_name(this_mesh_boundary_id)
<< "' (" << this_mesh_boundary_id << ").\n"
<< "Other mesh has " << other_boundary_node_ids.size()
<< " nodes on boundary " << other_mesh_boundary_id << ".\n";
<< " nodes on boundary `"
<< this->get_boundary_info().get_sideset_name(other_mesh_boundary_id)
<< "' (" << other_mesh_boundary_id << ").\n";

if (h_min_updated)
{
Expand Down