run-vmtest: fail selftest runs that produce kernel splats - #229
Merged
Conversation
theihor
requested changes
Aug 12, 2026
theihor
left a comment
theihor
left a comment
Contributor
There was a problem hiding this comment.
I created a vmtest PR for testing, and apparently there is pre-existing arm64 kasan splat: https://github.com/kernel-patches/vmtest/actions/runs/31545541634/job/93958798153?pr=508
That's good: the splat detection is working. But it also means we can't merge this before that splat is fixed. Do you want to look into it?
Alternatively, we can land this before the upstream fixes as non-blocking by reporting a warning or printing to summary. It will be mostly ignored then though.
A non-fatal splat (WARN, KASAN report, lockdep, hung task) leaves the VM running, so the selftest binary still exits 0 and CI goes green on a kernel that just hit a real bug. We have no signal for these today. Scan dmesg after the run and add a kernel_splats row to the existing exitstatus aggregator. What counts as a splat, and what is benign, is policy that differs per arch and per kernel, so it lives in $VMTEST_CONFIGS rather than in this action. A scan that cannot run fails the row rather than reporting clean: with no denylist there is no check, and a silently disabled detector is worse than none. Assisted-by: Claude:claude-opus-4-7 Signed-off-by: Mykyta Yatsenko <yatsenko@meta.com>
theihor
added a commit
to kernel-patches/vmtest
that referenced
this pull request
Aug 12, 2026
theihor
self-requested a review
August 12, 2026 23:44
theihor
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A non-fatal splat (WARN, KASAN report, lockdep, hung task) leaves the VM running, so the selftest binary still exits 0 and CI goes green on a kernel that just hit a real bug. We have no signal for these today.
Scan dmesg after the run and add a kernel_splats row to the existing exitstatus aggregator. A scan that cannot run fails the row rather than reporting clean, otherwise a typo in a pattern file would quietly turn the check off. splat-allowlist-file and skip-kernel-splat-check provide an escape hatch for known-benign matches.