restore native ca ssl option by default - #1316
Open
aouxwoux wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what changed
restore CURLSSLOPT_NATIVE_CA when a Session is constructed on curl 7.71.0 and newer.
why
#1128 correctly changed CURLOPT_SSL_OPTIONS to use one combined bitmask, but it moved the native-ca setting into SetSslOptions. that method is only called when ssl options are explicitly configured, so normal sessions no longer enable the native ca behavior on windows with openssl.
this keeps the bitmask fix in place while restoring the default constructor behavior. it also leaves the request preparation path free of repeated ssl-option writes.
checks
fixes #1313