Skip to content

restore native ca ssl option by default - #1316

Open
aouxwoux wants to merge 1 commit into
libcpr:masterfrom
aouxwoux:agent/restore-native-ca-default
Open

restore native ca ssl option by default#1316
aouxwoux wants to merge 1 commit into
libcpr:masterfrom
aouxwoux:agent/restore-native-ca-default

Conversation

@aouxwoux

@aouxwoux aouxwoux commented Aug 2, 2026

Copy link
Copy Markdown

what changed

restore CURLSSLOPT_NATIVE_CA when a Session is constructed on curl 7.71.0 and newer.

why

#1128 correctly changed CURLOPT_SSL_OPTIONS to use one combined bitmask, but it moved the native-ca setting into SetSslOptions. that method is only called when ssl options are explicitly configured, so normal sessions no longer enable the native ca behavior on windows with openssl.

this keeps the bitmask fix in place while restoring the default constructor behavior. it also leaves the request preparation path free of repeated ssl-option writes.

checks

  • git diff --check passes.
  • the local checkout does not have cmake or a c++ compiler installed, so i could not run the project test suite locally.

fixes #1313

@COM8 COM8 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @aouxwoux.

Once you are happy with it, feel free to mark the PR as ready for review.

@COM8 COM8 added the Bug 🐛 label Aug 3, 2026
@COM8 COM8 added this to the CPR 1.15.0 milestone Aug 3, 2026
@aouxwoux
aouxwoux marked this pull request as ready for review August 4, 2026 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regeession: CURLSSLOPT_NATIVE_CA is no longer automatically set

2 participants