Network.Fetch can fail in some cases

[arthurschreiber]

Looking over the Network.Fetch code, I think that it can fail in some specific scenarios:

If you load a Remote from a Repository, and it gets deleted by an external process in the time before being passed to Network.Fetch, Network.Fetch will try to reload it from the repository and fail.

[nulltoken]

@arthurschreiber ❤️ ‼️ for reporting this.

Maybe dynamically creating an in-memory remote from the passed in Remote and fetching from it could protect us from this? We already leverage disposable remotes here.

[arthurschreiber]

Yeah, I think that makes sense. I'll look into adding a git_remote_dup function to libgit2, as to make this easier to handle for the different bindings.

[jamill]

Just curious - is this an issue that you are running into? or is this something that you noticed could happen?

[arthurschreiber]

@jamill Nah, I don't use libgit2sharp - it's just something I stumbled upon while looking into how some things are implemented in the other libgit2 bindings.