Diff #103
Merged
Diff #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turns out a GTRepository would be a useful thing to have. WHO KNEW?!
Way better, as we don't have to do a foreach to get at it and we can be in control of it's lifecycle.
|
🎱 (note that there are 3 remaining tasks before this is mergeable btw) See also #111, I figure I will address all the various style problems with the old-skool unit tests when doing that. |
Lacking documentation is due to vague-ass stuff in diff.h. Waiting on some libgit2 folks to clarify a few things.
Also update our documentation to reflect the clarifications in libgit2.
This clone stuff is a bit lulzy.
|
OK @jspahrsummers I've written the tests I wanted to write. Go HAM :) |
ObjectiveGitTests/GTDiffSpec.m
Outdated
There was a problem hiding this comment.
I mean to move the block initialization into the beforeEach block, instead of doing it out here.
Specta might invoke this after the outer block returns because I'm pretty sure the it blocks just register things to test (they don't actually occur immediately).
There was a problem hiding this comment.
Ahhh I see, that makes sense.
ObjectiveGitTests/GTDiffTest.h
Outdated
|
🔥 Just a couple last notes. |
|
🇬🇧 |
|
|
jspahrsummers
added a commit
that referenced
this pull request
Dec 18, 2012
phatblat
pushed a commit
to phatblat/objective-git
that referenced
this pull request
May 29, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wraps the wonders of libgit2's diff as well as bumping it to a more recent version.
Also adds another, more involved, repository fixture and moves our fixtures into a zip file which is unzipped at test-time.
Remaining Functionality
Remaining Tests