Skip to content

Fix incorrect error message in assert functions #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alecjacobson merged 1 commit into from
Feb 1, 2023
Merged

Fix incorrect error message in assert functions #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/include/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ void assert_valid_3d_tri_mesh(const TV& v, const TF& f, std::string v_name="v",
".shape = [" + std::to_string(v.rows()) + ", " + std::to_string(v.cols()) + "]");
}
if (f.cols() != 3) {
throw pybind11::value_error("Invalid mesh faces, " + f_name + " must have shape [#faces, 4] but got " + f_name +
throw pybind11::value_error("Invalid mesh faces, " + f_name + " must have shape [#faces, 3] but got " + f_name +
".shape = [" + std::to_string(f.rows()) + ", " + std::to_string(f.cols()) + "]");
}
}
Expand Down Expand Up @@ -265,7 +265,7 @@ void assert_valid_23d_tri_mesh(const TV &v, const TF &f, std::string v_name = "v
}
if (f.cols() != 3)
{
throw pybind11::value_error("Invalid mesh faces, " + f_name + " must have shape [#faces, 4] but got " + f_name +
throw pybind11::value_error("Invalid mesh faces, " + f_name + " must have shape [#faces, 3] but got " + f_name +
".shape = [" + std::to_string(f.rows()) + ", " + std::to_string(f.cols()) + "]");
}
}
Expand Down