enum type size to match the definition in cl.h - #85
Merged
Conversation
thewilsonator
approved these changes
Dec 15, 2025
Collaborator
|
Thanks! |
takinutani
added a commit
to takinutani/dcompute
that referenced
this pull request
Dec 22, 2025
(cherry picked from commit f5bbded)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #84
The third parameter of clGetDeviceInfo() requires specifying the size of the retrieved data.
When retrieving enum type fields, the type size did not match the OpenCL specification.
(Enum base type is
int, whereas the OpenCL specification usescl_ulong)Therefore, we were unable to obtain the correct information.
By aligning the enum base type with OpenCL types, we ensure that the correct values can be obtained.