USB to Serial with RS485 driver control#46
Open
karlp wants to merge 1 commit intolibopencm3:masterfrom
Open
Conversation
Member
Author
|
👎 This is missing a file that didn't get added to git, will fix and resubmit |
Based on the existing lm4f implementation of cdc-acm to uart, and the existing f4 cdc-acm loop back examples, this includes the ST appnote code on managing rs485 signals
Member
Author
|
This is now ready to go, and the dependent changes are in the library now too. |
Contributor
|
Nice piece of code. |
Member
Author
|
🔴 I've had a few problems with bulk transfers through this, so hold off on it for now, need to figure out if it's a problem with my host app or this code first :( |
Member
Author
|
I've revisited this, and it's definitely a problem in this code. zmodem transfers don't seem to work being sent from this firmware, but it will receive ok at lower baud rates, with lots of errors. Probably not handling usb properly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on ST's app note and the existing examples.
This relies on libopencm3/libopencm3#246 being merged, and this pull cannot be merged without it, as it doesn't include the update of the submodule. It is here in it's present form for review, but will be updated with the submodule update later.
This also starts to split up some of the usb cdcd code that is copypasta all over the examples tree to have more chunks that can be shared