PWX-26307: Use default gce account when device level account not prov…#105
Merged
pp511 merged 1 commit intolibopenstorage:masterfrom Aug 17, 2022
Conversation
…ided for encryption Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ided for encryption
Signed-off-by: Priyanshu Pandey ppandey@purestorage.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #PWX-26307 [https://portworx.atlassian.net/browse/PWX-26307]
Special notes for your reviewer:
https://github.com/portworx/porx/pull/9762 has already been created to add support for disk encryption using customer managed key.
Customer should be able to provide Encrypt/Decrypt on their default gce account for disk encryption so that if device level kms account is not provided then