PWX-24572 : Set and Get InstanceGroupSize implementation#108
PWX-24572 : Set and Get InstanceGroupSize implementation#108vinayakshnd merged 6 commits intolibopenstorage:masterfrom nikita-bhatia:PWX-24572
Conversation
| UpdateNodePoolDetails: containerengine.UpdateNodePoolDetails{ | ||
| NodeConfigDetails: &containerengine.UpdateNodePoolNodeConfigDetails{ | ||
| Size: &totalClusterSize, | ||
| PlacementConfigs: nodePoolPlacementConfigDetails, |
There was a problem hiding this comment.
Here, we are not making any changes to placementConfig and it's not a required (must) field. We can skip creating a duplicate nodePoolPlacementConfigDetails, if oracle SDK allows that.
There was a problem hiding this comment.
nodePoolPlacementConfigDetails is required to equally balance creation and deletion of instances in each availability domain. We need to provide one placement configuration for each availability domain in which we intend to launch a node.
| WorkRequestId: opcWorkRequestID} | ||
|
|
||
| f := func() (interface{}, bool, error) { | ||
| workResp, err := client.GetWorkRequest(context.Background(), workReq) |
There was a problem hiding this comment.
GetNodePool API needs to be used to check lifecycle state of node pool is ACTIVE.
As additional check, (if required,) call GetInstanceGroupSize to verify number of active worker nodes matches with expected count.
There was a problem hiding this comment.
The state of work request changes from Accepted-> InProgress -> Succeeded, till all the instances are active. Oracle SDK provides this functionality to track the status of any work request submitted till done.
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
=========================================
- Coverage 7.65% 7.53% -0.12%
=========================================
Files 17 17
Lines 4219 4286 +67
=========================================
Hits 323 323
- Misses 3877 3944 +67
Partials 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
3 participants
Task : https://portworx.atlassian.net/browse/PWX-24572
Changes Done :
Tests done :