Skip to content

[PWX-26478] Specified timeout for http client required for Oracle metadata lookup #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vinayakshnd merged 1 commit into from
Aug 26, 2022
Merged

[PWX-26478] Specified timeout for http client required for Oracle metadata lookup #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions oracle/oracle.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
"os"
"strings"
"sync"
"time"

"github.com/libopenstorage/cloudops"
"github.com/oracle/oci-go-sdk/v65/common"
Expand Down Expand Up @@ -67,7 +68,6 @@ func NewClient() (cloudops.Ops, error) {
oracleOps := &oracleOps{}
err := getInfoFromMetadata(oracleOps)
if err != nil {
fmt.Printf("Got error [%v] from metadata\n", err)
err = getInfoFromEnv(oracleOps)
if err != nil {
return nil, err
Expand Down Expand Up @@ -130,7 +130,9 @@ func getInfoFromEnv(oracleOps *oracleOps) error {

func getRequest(endpoint string, headers map[string]string) (map[string]interface{}, int, error) {
metadata := make(map[string]interface{})
client := &http.Client{}
client := &http.Client{
Timeout: 15 * time.Second,
}
req, err := http.NewRequest("GET", endpoint, nil)
if err != nil {
return metadata, 0, err
Expand Down