PWX-24576: Implement clouddrive Expand API in CloudOps#113
Merged
nikita-bhatia merged 4 commits intolibopenstorage:masterfrom Sep 9, 2022
Merged
PWX-24576: Implement clouddrive Expand API in CloudOps#113nikita-bhatia merged 4 commits intolibopenstorage:masterfrom
nikita-bhatia merged 4 commits intolibopenstorage:masterfrom
Conversation
vinayakshnd
suggested changes
Sep 5, 2022
| return false | ||
| } | ||
|
|
||
| func (o *oracleOps) Expand(volumeID string, newSizeInGiB uint64) (uint64, error) { |
Contributor
There was a problem hiding this comment.
First check the current size of the disk. If requested newSizeInGiB is less than or equal to current size then return an error.
Take a look at how are we currently doing in AWS: https://github.com/libopenstorage/cloudops/blob/master/aws/aws.go#L937
Codecov Report
@@ Coverage Diff @@
## master #113 +/- ##
=========================================
+ Coverage 7.36% 7.43% +0.06%
=========================================
Files 17 17
Lines 4383 4345 -38
=========================================
Hits 323 323
+ Misses 4041 4003 -38
Partials 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira ticket : https://portworx.atlassian.net/browse/PWX-24576
Changes done :
Implemented Expand API for Oracle cloud
Tests done :
Verified Expansion of disk with and without attachment to instance.