Skip to content

Removed additional devicePath lookup after Attaching the volume.#114

Merged
vinayakshnd merged 2 commits intolibopenstorage:masterfrom
vinayakshnd:removeDevicePathLookup
Sep 20, 2022
Merged

Removed additional devicePath lookup after Attaching the volume.#114
vinayakshnd merged 2 commits intolibopenstorage:masterfrom
vinayakshnd:removeDevicePathLookup

Conversation

@vinayakshnd
Copy link
Copy Markdown
Contributor

@vinayakshnd vinayakshnd commented Sep 12, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes (optional)
Closes #

Special notes for your reviewer:

Below test passed:

go test -v .
=== RUN   TestAll
2022/09/15 07:25:41 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [PROVISIONING] state Next retry in: 3s
2022/09/15 07:25:44 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [PROVISIONING] state Next retry in: 3s
2022/09/15 07:25:48 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [PROVISIONING] state Next retry in: 3s
Created disk: { AvailabilityDomain=zSZL:US-SANJOSE-1-AD-1 CompartmentId=ocid1.compartment.oc1..aaaaaaaaxalgtzvncgpshcpiynag6aq5z36vwh63b3aaj63ay3ymkhxgprvq DisplayName=openstorage-test-d4c65356-2930-4c43-966a-906c079612ff Id=ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua LifecycleState=AVAILABLE SizeInMBs=51200 TimeCreated=2022-09-15 07:25:41.771 +0000 UTC DefinedTags=map[Oracle-Tags:map[CreatedBy:oracleidentitycloudservice/vshinde CreatedOn:2022-09-15T07:25:41.745Z]] FreeformTags=map[] SystemTags=map[] IsHydrated=true KmsKeyId=<nil> VpusPerGB=10 SizeInGBs=50 SourceDetails=<nil> VolumeGroupId=<nil> IsAutoTuneEnabled=false AutoTunedVpusPerGB=<nil> BlockVolumeReplicas=[] }
successfully tagd.2022/09/15 07:25:52 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:25:55 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:25:58 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:26:01 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:26:04 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:26:07 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
[ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] attached on path [/dev/oracleoci/oraclevdf]
2022/09/15 07:26:11 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [DETACHING] state Next retry in: 3s
2022/09/15 07:26:14 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [DETACHING] state Next retry in: 3s
2022/09/15 07:26:18 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [DETACHING] state Next retry in: 3s
2022/09/15 07:26:21 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [DETACHING] state Next retry in: 3s
2022/09/15 07:26:24 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [DETACHING] state Next retry in: 3s
2022/09/15 07:26:27 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [DETACHING] state Next retry in: 3s
2022/09/15 07:26:31 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [DETACHING] state Next retry in: 3s
2022/09/15 07:26:34 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [DETACHING] state Next retry in: 3s
2022/09/15 07:26:41 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:26:44 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:26:48 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:26:51 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:26:54 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
2022/09/15 07:26:57 volume [ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua] is still in [ATTACHING] state Next retry in: 3s
time="2022-09-15T07:27:00Z" level=info msg="disk: ocid1.volume.oc1.us-sanjose-1.abzwuljr6n3vsnjqk2sp75ryjnjkz27zzsw3by4agpigxxg6dpla5twpr5ua attached at: /dev/oracleoci/oraclevdf"
--- PASS: TestAll (79.41s)
PASS
ok      github.com/libopenstorage/cloudops/oracle       79.419s

Comment thread oracle/oracle.go
Comment thread oracle/oracle.go
@vinayakshnd vinayakshnd force-pushed the removeDevicePathLookup branch from 24871a3 to ac9678f Compare September 15, 2022 07:34
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 15, 2022

Codecov Report

Base: 7.33% // Head: 7.31% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (5982402) compared to base (0cbeca2).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #114      +/-   ##
=========================================
- Coverage    7.33%   7.31%   -0.02%     
=========================================
  Files          17      17              
  Lines        4406    4418      +12     
=========================================
  Hits          323     323              
- Misses       4064    4076      +12     
  Partials       19      19              
Impacted Files Coverage Δ
oracle/oracle.go 7.78% <0.00%> (-0.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vinayakshnd vinayakshnd merged commit f48e0df into libopenstorage:master Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants