[PWX-27134] Filter out only disks whos lifecycleState is ATTACHED in DeviceMappings() for oracle.#115
Merged
vinayakshnd merged 1 commit intolibopenstorage:masterfrom Oct 4, 2022
Conversation
DeviceMappings() for oracle. Signed-off-by: Vinayak Shinde <vinayakshnd@gmail.com>
Codecov ReportBase: 7.33% // Head: 7.19% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #115 +/- ##
=========================================
- Coverage 7.33% 7.19% -0.14%
=========================================
Files 17 17
Lines 4406 4488 +82
=========================================
Hits 323 323
- Misses 4064 4146 +82
Partials 19 19
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nrevanna
reviewed
Oct 4, 2022
| } else { | ||
| logrus.Warnf("Device path or volume id for [%+v] volume attachment not found", va) | ||
| continue | ||
| if va.GetLifecycleState() == core.VolumeAttachmentLifecycleStateAttached { |
Contributor
There was a problem hiding this comment.
Should we not consider VolumeAttachmentLifecycleStateAttaching also?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
ListVolumeAttachments()oracle SDK API returns all volume attachements including the ones that are currently detached. So, we need to filter out only ones which are inATTACHEDstate.Signed-off-by: Vinayak Shinde vinayakshnd@gmail.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: