PWX-27046: Avoid panic when drive type is not specified.#118
Merged
pp511 merged 2 commits intolibopenstorage:masterfrom Oct 12, 2022
Merged
PWX-27046: Avoid panic when drive type is not specified.#118pp511 merged 2 commits intolibopenstorage:masterfrom
pp511 merged 2 commits intolibopenstorage:masterfrom
Conversation
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
nrevanna
approved these changes
Oct 12, 2022
Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Priyanshu Pandey ppandey@purestorage.com
What this PR does / why we need it:
*vol.VolumeType results into nil pointer dereferencing. This occurs when drive type is not specified in the deviceSpec.
Also some indentation issues where auto fixed by the ide.
Which issue(s) this PR fixes (optional)
Closes # PWX-27046