Skip to content

PWX-28363: Improving DeviceMapping to reduce api calls#124

Merged
nrevanna merged 1 commit intomasterfrom
hsbc_sync_is_locally_attached
Dec 23, 2022
Merged

PWX-28363: Improving DeviceMapping to reduce api calls#124
nrevanna merged 1 commit intomasterfrom
hsbc_sync_is_locally_attached

Conversation

@nrevanna
Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional)
Closes #

Special notes for your reviewer:

@nrevanna nrevanna requested a review from pp511 December 23, 2022 23:04
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Base: 8.18% // Head: 8.17% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (fed46fa) compared to base (1f27357).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #124      +/-   ##
=========================================
- Coverage    8.18%   8.17%   -0.01%     
=========================================
  Files          18      18              
  Lines        4620    4624       +4     
=========================================
  Hits          378     378              
- Misses       4220    4224       +4     
  Partials       22      22              
Impacted Files Coverage Δ
vsphere/vsphere.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Copy Markdown
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nrevanna nrevanna merged commit c33708f into master Dec 23, 2022
@nrevanna nrevanna deleted the hsbc_sync_is_locally_attached branch December 23, 2022 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants