Volume check functionality#127
Merged
alicelyy merged 8 commits intolibopenstorage:masterfrom Jan 30, 2023
Merged
Conversation
Codecov ReportBase: 8.17% // Head: 8.10% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #127 +/- ##
=========================================
- Coverage 8.17% 8.10% -0.07%
=========================================
Files 18 18
Lines 4624 4661 +37
=========================================
Hits 378 378
- Misses 4224 4261 +37
Partials 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
nrevanna
approved these changes
Jan 28, 2023
Contributor
nrevanna
left a comment
nrevanna
left a comment
There was a problem hiding this comment.
Looks good after addressing the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
ebs volumes experience four states on modification, see
https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/monitoring-volume-modifications.html
This pull request addresses an issue where a user attempts to expand a storage pool while aws has not yet completed the optimization process for the associated volume(s), which leads to a pool expand failure. By implementing a checker function for this scenario, we aim to catch the said scenario early and provide a clear and readable error message to the user.
Which issue(s) this PR fixes (optional)
PWX-28287
Special notes for your reviewer:
https://github.com/portworx/porx/pull/10496