Skip to content

PWX-29069: Handling panic in case of incorrect volume template#131

Merged
pp511 merged 1 commit intomasterfrom
PWX-29069
Feb 10, 2023
Merged

PWX-29069: Handling panic in case of incorrect volume template#131
pp511 merged 1 commit intomasterfrom
PWX-29069

Conversation

@pp511
Copy link
Copy Markdown
Contributor

@pp511 pp511 commented Feb 9, 2023

Signed-off-by: Priyanshu Pandey ppandey@purestorage.com

What this PR does / why we need it:
Handling panic due to nil DiskProperties when no param is specified in -s

Which issue(s) this PR fixes (optional)
Closes #https://portworx.atlassian.net/browse/PWX-29069

Special notes for your reviewer:

  • Issue is fixed after updating the volume template but we should handle this panic.
  • This was caused when trying to dereference d.DiskProperties.DiskSizeGB

Signed-off-by: Priyanshu Pandey <ppandey@purestorage.com>
@pp511 pp511 requested review from a team and nrevanna February 9, 2023 23:55
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 10, 2023

Codecov Report

Base: 8.10% // Head: 8.10% // No change to project coverage 👍

Coverage data is based on head (f9548d2) compared to base (d65a9e1).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #131   +/-   ##
======================================
  Coverage    8.10%   8.10%           
======================================
  Files          18      18           
  Lines        4664    4664           
======================================
  Hits          378     378           
  Misses       4264    4264           
  Partials       22      22           
Impacted Files Coverage Δ
azure/azure.go 0.56% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pp511 pp511 merged commit d6ee60e into master Feb 10, 2023
@piyush-nimbalkar piyush-nimbalkar deleted the PWX-29069 branch February 10, 2023 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants