[PWX-29160] Upgrade azure-sdk-for-go clients api to version '2021-07-01'#134
Merged
[PWX-29160] Upgrade azure-sdk-for-go clients api to version '2021-07-01'#134
Conversation
alicelyy
changed the title
nrevanna
reviewed
Feb 22, 2023
| k8s.io/klog v1.0.0 | ||
| ) | ||
|
|
||
| require ( |
Contributor
There was a problem hiding this comment.
I think we should have a single require section and not two.
@dahuang-purestorage ?
Also, do you see any concerns with these many require additions?
Contributor
There was a problem hiding this comment.
this is fine. that's a new change in 1.17 where they separate require for direct and indirect dependencies.
nrevanna
reviewed
Feb 22, 2023
Contributor
nrevanna
left a comment
nrevanna
left a comment
There was a problem hiding this comment.
- Azure code changes look good to me
- Please wait in Daniel's comments for go.mod changes.
nrevanna
approved these changes
Feb 22, 2023
dahuang-purestorage
approved these changes
Feb 23, 2023
Contributor
dahuang-purestorage
left a comment
dahuang-purestorage
left a comment
There was a problem hiding this comment.
LGTM on the go mod side
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Upgrade azure-sdk-for-go client api to version '2021-07-01`
This is needed to support no-down-time resize for azure clusters.
Special notes for your reviewer:
Tried to run BVT/FVT following wiki
https://portworx.atlassian.net/wiki/spaces/PE/pages/440631299/Running+BVT+FVT+on+branches
Build failed for unrelated failures, see https://jenkins.pwx.dev.purestorage.com/job/Dev/job/Porx-02/196/
travis build for porx with this branch succeeded https://github.com/portworx/porx/commit/c9dfb809e5ec977c3acd4081eb54697201395e7c