PWX-28882: Fix Nomad support issues for vSphere provider#137
Merged
PWX-28882: Fix Nomad support issues for vSphere provider#137
Conversation
Configmap apis were used in vSphere provider which stopped px from
coming up on Nomad. The following changes are made
- Store interface moved to cloudops
- DriveSetStore interface created with Store as composite. Contains
interfaces with DriveSet datastructure.
- GetLockTryDuration introduced
- Renamed GetLockTimeout/SetLockTimeout to
GetLockHoldTimeout/SetLockHoldTimeout.
- Implemented IsKeyLocked() and LockWithKey() interfaces in kv_store
- Removed noOpStore implementation. It was a stop gap solution for
lack of implementation in kv_store
Signed-off-by: Naveen Revanna <nrevanna@purestorage.com>
pureneelesh
reviewed
Mar 23, 2023
adityadani
approved these changes
Mar 24, 2023
Contributor
adityadani
left a comment
adityadani
left a comment
There was a problem hiding this comment.
lgtm after comments are addressed
adityadani
reviewed
Mar 25, 2023
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #137 +/- ##
=========================================
- Coverage 8.09% 8.07% -0.02%
=========================================
Files 18 18
Lines 4672 4681 +9
=========================================
Hits 378 378
- Misses 4272 4281 +9
Partials 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer: