Conversation
vSphere client is being used in some paths which were being ignored
thinking it's not needed. Reenabling them
Signed-off-by: Naveen Revanna <nrevanna@purestorage.com>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
=========================================
- Coverage 8.07% 8.06% -0.01%
=========================================
Files 18 18
Lines 4681 4686 +5
=========================================
Hits 378 378
- Misses 4281 4286 +5
Partials 22 22
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
| storeLock *store.Lock | ||
| lockErr error | ||
| ) | ||
| if ops.dsLock != nil { |
There was a problem hiding this comment.
Should we explicitly error out if dsLock is nil?
I know that there is no code that invokes this function without initializing store. I am trying to future proof it to ensure recommendDatastore is always called with store initialized.
There was a problem hiding this comment.
Sure.. Let me do that in a different ticket
https://portworx.atlassian.net/browse/PWX-30121
3 participants
What this PR does / why we need it:
Which issue(s) this PR fixes (optional)
Closes #
Special notes for your reviewer:
Testing:
Ran the fix on the cluster provided by Santhosh and px came up.