Skip to content

Health monitor: Node matching logic needs updating #144

@disrani-px

Description

@disrani-px

Is this a BUG REPORT or FEATURE REQUEST?:
BUG

What happened:
The node name matching logic in the health monitor has not been updated like the extender, so it will fail to match nodes on some configurations. Need to use the same logic as the extender.

What you expected to happen:
Be able to monitor and delete pods on nodes with offline storage in all kubernetes configurations.

How to reproduce it (as minimally and precisely as possible):
On K8s on DC/OS, stop the storage driver on a node with a pod. stork will fail to delete the pod since it won't watch the k8s node to the storage node.

Anything else we need to know?:
Will also affect AWS where node names and hostnames are weird.

Environment:

  • Kubernetes version (use kubectl version):
  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions