PWX-22971 : Fix application clone failure at resource stage#1046
Merged
ram-infrac merged 4 commits intomasterfrom Feb 25, 2022
Merged
PWX-22971 : Fix application clone failure at resource stage#1046ram-infrac merged 4 commits intomasterfrom
ram-infrac merged 4 commits intomasterfrom
Conversation
- get volume driverName by looking at pv object in case of non backup/restore prepareresource calls Signed-off-by: Ram <rsuradkar@purestorage.com>
ram-infrac
requested review from
Rohit-PX,
adityadani,
lpitstickpstg,
prashanthpx and
siva-portworx
Signed-off-by: Ram <rsuradkar@purestorage.com>
ram-infrac
force-pushed
the
PWX-22971
branch
from
dacb618 to
2a04400
Compare
| // node offline timeout just above 4.5 minutes | ||
| // which is the max time stork could take to delete a app pod. | ||
| nodeOfflineTimeout = 271 * time.Second | ||
| nodeOfflineTimeout = 295 * time.Second |
Contributor
There was a problem hiding this comment.
Did performance degrade?
Contributor
Author
There was a problem hiding this comment.
No, health monitor switch period is still 4.5 mins.
Torpedo StopDriver() labels node to stop Portworx driver, but does not actually waits for driver to shutdown only grace period of 10 Secs for some reason. that's why this increase timeout is needed
Contributor
Author
There was a problem hiding this comment.
@Rohit-PX I think we should fix in torpedo will need it eventually https://github.com/portworx/torpedo/blob/master/drivers/volume/portworx/portworx.go#L1374
adityadani
approved these changes
Feb 25, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
ApplicationClone fails with error -
This PR fix issue where driverName is always empty for non backup/restore,
PrepareResourceForApplycallDoes this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
yes2.9
2.8 -> in case of backup release of 2.8.x
Jenkins Job :