Skip deleted namespaces from a migration schedule#1090
Merged
Rohit-PX merged 1 commit intolibopenstorage:masterfrom May 12, 2022
Merged
Skip deleted namespaces from a migration schedule#1090Rohit-PX merged 1 commit intolibopenstorage:masterfrom
Rohit-PX merged 1 commit intolibopenstorage:masterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
ced5568 to
3ad4b87
Compare
lpitstickpstg
approved these changes
May 3, 2022
pkg/apis/stork/v1alpha1/migration.go
Outdated
| PreExecRule string `json:"preExecRule"` | ||
| PostExecRule string `json:"postExecRule"` | ||
| IncludeOptionalResourceTypes []string `json:"includeOptionalResourceTypes"` | ||
| SkipDeletedNamespaces bool `json:"skipDeletedNamespaces"` |
Contributor
There was a problem hiding this comment.
Does this default to False?
The other bools here are *bool
Contributor
Author
There was a problem hiding this comment.
Yes it will default to false, but fixed it to maintain code standards.
6bdb89b to
12b7e9d
Compare
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
ed5da42 to
90746af
Compare
ram-infrac
approved these changes
May 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Rohit-PX rkulkarni@purestorage.com
What type of PR is this?
improvement
What this PR does / why we need it:
Improvement can be as below:
Does this PR change a user-facing CRD or CLI?:
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?:
2.11