Skip to content

Skip deleted namespaces from a migration schedule#1090

Merged
Rohit-PX merged 1 commit intolibopenstorage:masterfrom
Rohit-PX:deleted_ns_migsched
May 12, 2022
Merged

Skip deleted namespaces from a migration schedule#1090
Rohit-PX merged 1 commit intolibopenstorage:masterfrom
Rohit-PX:deleted_ns_migsched

Conversation

@Rohit-PX
Copy link
Copy Markdown
Contributor

@Rohit-PX Rohit-PX commented May 3, 2022

Signed-off-by: Rohit-PX rkulkarni@purestorage.com

What type of PR is this?
improvement

What this PR does / why we need it:

  • In a migration schedule, if a namespace that is present in the migration schedule is deleted, then we throw an error and fail subsequently triggered migrations
  • This results in stoppage of migrations for namespaces that are still present and which the user would like to be migrated

Improvement can be as below:

  • Even if a deleted namespace is present in a migration schedule, add warning messages but proceed with migration of other namespaces.
  • Add flag in the migration schedule spec to proceed with migrations for other namespaces even if some namespaces are deleted.

Does this PR change a user-facing CRD or CLI?:

Is a release note needed?:

Issue:  https://portworx.atlassian.net/browse/PWX-23459
User Impact: 
Namespaces that are deleted but are present in the migration schedule namespaces list those migrations were being marked as failed. 
Resolution:
Migration schedule spec will have a new bool field: SkipDeletedNamespaces that will determine if migrations are to be marked as failed in case some namespaces are deleted.

Does this change need to be cherry-picked to a release branch?:
2.11

@cnbu-jenkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@Rohit-PX Rohit-PX force-pushed the deleted_ns_migsched branch from ced5568 to 3ad4b87 Compare May 3, 2022 08:05
PreExecRule string `json:"preExecRule"`
PostExecRule string `json:"postExecRule"`
IncludeOptionalResourceTypes []string `json:"includeOptionalResourceTypes"`
SkipDeletedNamespaces bool `json:"skipDeletedNamespaces"`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this default to False?
The other bools here are *bool

Copy link
Copy Markdown
Contributor Author

@Rohit-PX Rohit-PX May 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it will default to false, but fixed it to maintain code standards.

@Rohit-PX Rohit-PX force-pushed the deleted_ns_migsched branch 2 times, most recently from 6bdb89b to 12b7e9d Compare May 11, 2022 06:19
Signed-off-by: Rohit-PX <rkulkarni@purestorage.com>
@Rohit-PX Rohit-PX force-pushed the deleted_ns_migsched branch from ed5da42 to 90746af Compare May 11, 2022 06:23
@Rohit-PX Rohit-PX merged commit 3fce175 into libopenstorage:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants