PWX-23579 : Allow setting QPS & Burst rate for storkctl command#1094
Merged
ram-infrac merged 2 commits intomasterfrom May 18, 2022
Merged
PWX-23579 : Allow setting QPS & Burst rate for storkctl command#1094ram-infrac merged 2 commits intomasterfrom
ram-infrac merged 2 commits intomasterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
ac573bc to
d61bf29
Compare
Codecov Report
@@ Coverage Diff @@
## master #1094 +/- ##
==========================================
- Coverage 68.75% 68.72% -0.03%
==========================================
Files 42 42
Lines 4583 4611 +28
==========================================
+ Hits 3151 3169 +18
- Misses 1120 1128 +8
- Partials 312 314 +2
Continue to review full report at Codecov.
|
adityadani
approved these changes
May 16, 2022
Contributor
adityadani
left a comment
There was a problem hiding this comment.
lgtm after comments are fixed
added 2 commits
May 18, 2022 11:09
Signed-off-by: Ram <rsuradkar@purestorage.com>
…tion Signed-off-by: Ram <rsuradkar@purestorage.com>
Contributor
Author
|
yup, I opened pr for two feature at same time and put in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR add support to set QPS & Burst rate for storkctl command.
Does this PR change a user-facing CRD or CLI?:
yes
Is a release note needed?:
yes
Does this change need to be cherry-picked to a release branch?:
yes, 2.11