Skip to content

PWX-23579 : Allow setting QPS & Burst rate for storkctl command#1094

Merged
ram-infrac merged 2 commits intomasterfrom
pwx-23579
May 18, 2022
Merged

PWX-23579 : Allow setting QPS & Burst rate for storkctl command#1094
ram-infrac merged 2 commits intomasterfrom
pwx-23579

Conversation

@ram-infrac
Copy link
Copy Markdown
Contributor

What type of PR is this?

enhancement

What this PR does / why we need it:
This PR add support to set QPS & Burst rate for storkctl command.

Does this PR change a user-facing CRD or CLI?:
yes

# time ./bin/linux/storkctl activate migration -nopenshift4-debug --qps 500 --burst 100

real	0m0.844s
user	0m0.176s
sys	0m0.046s

Is a release note needed?:
yes

Issue: storkctl activate takes too much time 
User Impact:  Activate/Deactivate migrated apps takes too much time
Resolution: storkctl now accept qps and burst rate for limiting k8s api queries 

Does this change need to be cherry-picked to a release branch?:
yes, 2.11

@ram-infrac ram-infrac added this to the 2.11.0 milestone May 9, 2022
@ram-infrac ram-infrac self-assigned this May 9, 2022
@cnbu-jenkins
Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@ram-infrac ram-infrac force-pushed the pwx-23579 branch 2 times, most recently from ac573bc to d61bf29 Compare May 10, 2022 12:33
@codecov
Copy link
Copy Markdown

codecov bot commented May 10, 2022

Codecov Report

Merging #1094 (5186227) into master (59d8663) will decrease coverage by 0.02%.
The diff coverage is 64.28%.

❗ Current head 5186227 differs from pull request most recent head cad0006. Consider uploading reports for the commit cad0006 to get more accurate results

@@            Coverage Diff             @@
##           master    #1094      +/-   ##
==========================================
- Coverage   68.75%   68.72%   -0.03%     
==========================================
  Files          42       42              
  Lines        4583     4611      +28     
==========================================
+ Hits         3151     3169      +18     
- Misses       1120     1128       +8     
- Partials      312      314       +2     
Impacted Files Coverage Δ
pkg/storkctl/migration.go 51.79% <63.63%> (+0.44%) ⬆️
pkg/storkctl/factory.go 63.38% <66.66%> (+0.30%) ⬆️
pkg/extender/extender.go 78.52% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59d8663...cad0006. Read the comment docs.

Copy link
Copy Markdown
Contributor

@adityadani adityadani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm after comments are fixed

Ram added 2 commits May 18, 2022 11:09
Signed-off-by: Ram <rsuradkar@purestorage.com>
…tion

Signed-off-by: Ram <rsuradkar@purestorage.com>
@ram-infrac
Copy link
Copy Markdown
Contributor Author

yup, I opened pr for two feature at same time and put in storkctl changes in one PR

@ram-infrac ram-infrac merged commit 909dd2b into master May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants