Skip to content

PB-7579: Creation of webhook controller in runtime should be only if stork is running with a driver.#1813

Merged
diptiranjanpx merged 1 commit intomasterfrom
PB-7579
Jul 12, 2024
Merged

PB-7579: Creation of webhook controller in runtime should be only if stork is running with a driver.#1813
diptiranjanpx merged 1 commit intomasterfrom
PB-7579

Conversation

@diptiranjanpx
Copy link
Copy Markdown
Contributor

@diptiranjanpx diptiranjanpx commented Jul 12, 2024

Signed-Off-By: Diptiranjan

What type of PR is this?
bug

What this PR does / why we need it:
For cases where stork cmd runs without --driver, skip running CreateMutateWebhookRuntime even if webhook has been enabled. PX-Backup may run with above mode in non-px clusters.

Does this PR change a user-facing CRD or CLI?:
no

Is a release note needed?:
no

Does this change need to be cherry-picked to a release branch?:
yes, 24.2.4 and 24.3.0

Test:
In non-px cluster stork is running fine

[root@ip-10-13-11-25 ~]# kubectl -n kube-system get po -lname=stork
NAME                     READY   STATUS    RESTARTS   AGE
stork-5649dc48d8-r464p   1/1     Running   0          4m59s
stork-5649dc48d8-rwmd7   1/1     Running   0          5m11s
stork-5649dc48d8-vmrnm   1/1     Running   0          5m24s


[root@ip-10-13-11-25 ~]# kubectl -n kube-system get po stork-5649dc48d8-r464p -o json | jq .spec.containers[0].command
[
  "/stork",
  "--verbose",
  "--leader-elect=true",
  "--health-monitor-interval=120",
  "--webhook-controller=true"
]

Copy link
Copy Markdown
Contributor

@pp511 pp511 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I missed this point in the previous PR.

@diptiranjanpx diptiranjanpx merged commit a6770a0 into master Jul 12, 2024
diptiranjanpx added a commit that referenced this pull request Jul 12, 2024
diptiranjanpx added a commit that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants