PB-7579: Creation of webhook controller in runtime should be only if stork is running with a driver.#1813
Merged
diptiranjanpx merged 1 commit intomasterfrom Jul 12, 2024
Merged
Conversation
pp511
approved these changes
Jul 12, 2024
Contributor
pp511
left a comment
There was a problem hiding this comment.
LGTM. I missed this point in the previous PR.
…stork is running with a driver.
strivedi-px
approved these changes
Jul 12, 2024
diptiranjanpx
added a commit
that referenced
this pull request
Jul 12, 2024
…stork is running with a driver. (#1813)
diptiranjanpx
added a commit
that referenced
this pull request
Jul 12, 2024
…stork is running with a driver. (#1813)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-Off-By: Diptiranjan
What type of PR is this?
bug
What this PR does / why we need it:
For cases where stork cmd runs without --driver, skip running CreateMutateWebhookRuntime even if webhook has been enabled. PX-Backup may run with above mode in non-px clusters.
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
no
Does this change need to be cherry-picked to a release branch?:
yes, 24.2.4 and 24.3.0
Test:
In non-px cluster stork is running fine