Skip to content

Extender: Return error if no replicas are online for a volume#299

Merged
disrani-px merged 1 commit intomasterfrom
extender_no_replicas
Mar 20, 2019
Merged

Extender: Return error if no replicas are online for a volume#299
disrani-px merged 1 commit intomasterfrom
extender_no_replicas

Conversation

@disrani-px
Copy link
Copy Markdown
Contributor

What type of PR is this?
Bug (Related to #291)

What this PR does / why we need it:
If there are no replicas online for a PVC the pod should not get scheduled, since it will not be able to mount the volume anyways. This change returns an error from the Filter request to prevent scheduling such pods till atleast one node with the replica comes back online

Does this PR change a user-facing CRD or CLI?:

No

Is a release note needed?:

Extender will now return an error if no replicas for a volume are online. This will prevent pods from getting scheduled if they can not use a PVC.

Does this change need to be cherry-picked to a release branch?:
2.1

@disrani-px disrani-px added the bug label Mar 19, 2019
@disrani-px disrani-px added this to the 2.1.1 milestone Mar 19, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2019

Codecov Report

Merging #299 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #299      +/-   ##
==========================================
+ Coverage   73.45%   73.65%   +0.19%     
==========================================
  Files          19       19              
  Lines        1379     1389      +10     
==========================================
+ Hits         1013     1023      +10     
  Misses        282      282              
  Partials       84       84
Impacted Files Coverage Δ
pkg/extender/extender.go 85.16% <100%> (+0.74%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55fc1bf...2baeb94. Read the comment docs.

@disrani-px disrani-px merged commit f521df4 into master Mar 20, 2019
@disrani-px disrani-px added the release-note Information about this change needs to be added to the release note label Mar 20, 2019
@disrani-px disrani-px deleted the extender_no_replicas branch April 4, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug release-note Information about this change needs to be added to the release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants