Extender: Return error if no replicas are online for a volume#299
Merged
disrani-px merged 1 commit intomasterfrom Mar 20, 2019
Merged
Extender: Return error if no replicas are online for a volume#299disrani-px merged 1 commit intomasterfrom
disrani-px merged 1 commit intomasterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #299 +/- ##
==========================================
+ Coverage 73.45% 73.65% +0.19%
==========================================
Files 19 19
Lines 1379 1389 +10
==========================================
+ Hits 1013 1023 +10
Misses 282 282
Partials 84 84
Continue to review full report at Codecov.
|
piyush-nimbalkar
approved these changes
Mar 19, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug (Related to #291)
What this PR does / why we need it:
If there are no replicas online for a PVC the pod should not get scheduled, since it will not be able to mount the volume anyways. This change returns an error from the
Filterrequest to prevent scheduling such pods till atleast one node with the replica comes back onlineDoes this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?:
2.1