Skip to content

Add deploymentconfig to activate migrations for storkctl#375

Merged
disrani-px merged 1 commit intomasterfrom
dc_activate
May 17, 2019
Merged

Add deploymentconfig to activate migrations for storkctl#375
disrani-px merged 1 commit intomasterfrom
dc_activate

Conversation

@disrani-px
Copy link
Copy Markdown
Contributor

What type of PR is this?
Bug

What this PR does / why we need it:

Does this PR change a user-facing CRD or CLI?:
No

Is a release note needed?:

Storkctl: Activating DeploymentConfig for migrations

Does this change need to be cherry-picked to a release branch?:
2.2

@disrani-px disrani-px added this to the 2.2.3 milestone May 17, 2019
@disrani-px disrani-px requested a review from adityadani May 17, 2019 00:53
@disrani-px disrani-px added the bug label May 17, 2019
@codecov
Copy link
Copy Markdown

codecov bot commented May 17, 2019

Codecov Report

Merging #375 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #375      +/-   ##
==========================================
+ Coverage   72.48%   72.49%   +0.01%     
==========================================
  Files          24       24              
  Lines        2126     2127       +1     
==========================================
+ Hits         1541     1542       +1     
  Misses        453      453              
  Partials      132      132
Impacted Files Coverage Δ
pkg/storkctl/migration.go 76.95% <100%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6a79a8...a8a4ed3. Read the comment docs.

@disrani-px disrani-px merged commit 068f895 into master May 17, 2019
@disrani-px disrani-px deleted the dc_activate branch May 20, 2019 23:17
@disrani-px disrani-px added the release-note Information about this change needs to be added to the release note label May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug release-note Information about this change needs to be added to the release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants