Create some default schedule policies#385
Merged
disrani-px merged 1 commit intomasterfrom May 25, 2019
Merged
Conversation
disrani-px
added
enhancement
release-note
disrani-px
requested review from
adityadani,
harsh-px,
piyush-nimbalkar and
ram-infrac
disrani-px
force-pushed
the
default_policy
branch
from
a8e1770 to
1a634c6
Compare
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
==========================================
+ Coverage 72.5% 72.89% +0.38%
==========================================
Files 24 24
Lines 2128 2195 +67
==========================================
+ Hits 1543 1600 +57
- Misses 453 458 +5
- Partials 132 137 +5
Continue to review full report at Codecov.
|
Also update strokctl to use a default policy for migration schedule
disrani-px
force-pushed
the
default_policy
branch
from
1a634c6 to
c6cce6e
Compare
piyush-nimbalkar
approved these changes
May 25, 2019
| func createDefaultPolicy() error { | ||
| _, err := k8s.Instance().CreateSchedulePolicy(&stork_api.SchedulePolicy{ | ||
| ObjectMeta: meta.ObjectMeta{ | ||
| Name: "default-migration-policy", |
There was a problem hiding this comment.
should we call it migration policy or keep it generic?
Contributor
Author
There was a problem hiding this comment.
This is used specifically as the default for migrations when creating a schedule using storkctl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update strokctl to use a default policy for migration schedule
What type of PR is this?
Enhancement
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
Does this change need to be cherry-picked to a release branch?:
2.2