Prometheus metrics for stork extender and monitor#710
Conversation
Codecov Report
@@ Coverage Diff @@
## master #710 +/- ##
=========================================
Coverage ? 71.15%
=========================================
Files ? 35
Lines ? 3668
Branches ? 0
=========================================
Hits ? 2610
Misses ? 809
Partials ? 249
Continue to review full report at Codecov.
|
- added prometheus metrics for stork extenders which covers hyper,non and semi-hyperconverged pod counter - added stork monitor metrics for no of pod rescheduled by stork monitor Signed-off-by: Ram <ram.suradkar@portworx.com>
Signed-off-by: Ram <ram.suradkar@portworx.com>
Signed-off-by: Ram <ram.suradkar@portworx.com>
ram-infrac
force-pushed
the
metrics
branch
2 times, most recently
from
7e203ec to
3568181
Compare
disrani-px
added
the
release-note
| require.NoError(t, err, "failed to create pod") | ||
|
|
||
| time.Sleep(3 * time.Second) | ||
| require.Equal(t, testutil.ToFloat64(NonHyperConvergePodsCounter), float64(1), "non_hyperconverged_pods_total not matched") |
There was a problem hiding this comment.
Can you add test cases to delete the pods and make sure the 3 counters go to 0.
Also, can you verify the labels on the counter
There was a problem hiding this comment.
testutil needs to be updated with latest release for label check & 0 in ToFloat64()
There was a problem hiding this comment.
As discussed this will be done in a separate PR since it required some vendor updates which have conflicts
Signed-off-by: Ram <ram.suradkar@portworx.com>
Signed-off-by: Ram <ram.suradkar@portworx.com>
2 participants
What type of PR is this?
What this PR does / why we need it:
Adds prometheus metrics for stork extender and monitor
Does this PR change a user-facing CRD or CLI?:
no
Is a release note needed?:
yes, will be put in final pr part for stork prometheus metrics