Prune migrations even for PartialSuccess#742
Merged
disrani-px merged 2 commits intomasterfrom Nov 13, 2020
Merged
Conversation
Some resources might always fail to be migrated, this causes the status for all PartialSuccess migrations to be saved. Only need to keep the last one in this case
ram-infrac
approved these changes
Nov 13, 2020
Codecov Report
@@ Coverage Diff @@
## master #742 +/- ##
==========================================
+ Coverage 71.12% 71.20% +0.08%
==========================================
Files 35 35
Lines 3674 3674
==========================================
+ Hits 2613 2616 +3
+ Misses 811 809 -2
+ Partials 250 249 -1
Continue to review full report at Codecov.
|
disrani-px
added
the
release-note
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some resources might always fail to be migrated, this causes the status for all
PartialSuccess migrations to be saved. Only need to keep the last one in this
case
What type of PR is this?
Bug
What this PR does / why we need it:
Does this PR change a user-facing CRD or CLI?:
No
Is a release note needed?:
No
Does this change need to be cherry-picked to a release branch?:
No