Skip to content

fix kad quorum#271

Merged
turuslan merged 1 commit intomasterfrom
fix/kad-quorum
Oct 7, 2024
Merged

fix kad quorum#271
turuslan merged 1 commit intomasterfrom
fix/kad-quorum

Conversation

@turuslan
Copy link
Copy Markdown
Contributor

@turuslan turuslan commented Oct 5, 2024

  • insufficient quorum is not an error
    polkadot-sdk/substrate/client/network/src/discovery.rs:
         96: // The minimum number of peers we expect an answer before we terminate the request.
         97: const GET_RECORD_REDUNDANCY_FACTOR: u32 = 4;
        889:     Ok(GetRecordOk::FoundRecord(r)) => {
        899:       // Let's directly finish the query if we are above 4.
        905:       if stats.num_successes() > GET_RECORD_REDUNDANCY_FACTOR {
        908:         query.finish();
        917:       DiscoveryOut::ValueFound(r, stats.duration().unwrap_or_default())
        919:     Ok(GetRecordOk::FinishedWithNoAdditionalRecord {
    

Signed-off-by: turuslan <turuslan.devbox@gmail.com>
@turuslan turuslan requested a review from igor-egorov October 5, 2024 05:19
@turuslan turuslan merged commit 9a077cf into master Oct 7, 2024
@turuslan turuslan deleted the fix/kad-quorum branch October 7, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants