Skip to content

Increase required Go version to 1.19 in tutorial#121

Merged
salmad3 merged 2 commits intomasterfrom
go-116
Sep 1, 2022
Merged

Increase required Go version to 1.19 in tutorial#121
salmad3 merged 2 commits intomasterfrom
go-116

Conversation

@marten-seemann
Copy link
Copy Markdown
Contributor

@marten-seemann marten-seemann commented Dec 23, 2021 •
edited by salmad3
Loading

resolves #167

@BigLep
Copy link
Copy Markdown
Contributor

BigLep commented Jun 17, 2022

@marten-seemann : is this still relevant?

@marten-seemann
Copy link
Copy Markdown
Contributor Author

marten-seemann commented Jun 17, 2022

This is already outdated. We should find a way to write this such that we don’t have to update the version every 6 months.

@BigLep
Copy link
Copy Markdown
Contributor

BigLep commented Aug 19, 2022

2022-08-19 conversation: will cover in the one-off docs triage happening week of 2022-08-22.

@MarcoPolo
Copy link
Copy Markdown
Contributor

MarcoPolo commented Aug 19, 2022

Maybe we can just say the latest version - 1?

@MarcoPolo
Copy link
Copy Markdown
Contributor

MarcoPolo commented Aug 19, 2022

also we could figure this out at runtime with https://go.dev/dl/?mode=json and https://go.dev/VERSION?m=text

This was referenced Aug 26, 2022
Closed
Closed
salmad3
salmad3 requested changes Aug 29, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on #167, suggesting the following updates directly on this open PR.

To also bounce off the discussion on this PR and during the docs triage, we can add automation where the value is pulled in and injected onto the page, or, at the very least, an alert for new releases

Comment thread content/tutorials/getting-started/go.md Outdated
Comment thread content/tutorials/getting-started/go.md Outdated
Comment thread content/tutorials/getting-started/go.md Outdated
Comment thread content/tutorials/getting-started/go.md Outdated
@salmad3 salmad3 changed the title increase required Go version to 1.16 in tutorial Increase required Go version to 1.19 in tutorial Aug 29, 2022
@salmad3
Copy link
Copy Markdown
Contributor

salmad3 commented Aug 31, 2022

@p-shahi @marten-seemann had added suggestions to this open PR to update the version

@salmad3 salmad3 added ready for review PR is ready for review change request PR requires changes. labels Aug 31, 2022
marten-seemann
marten-seemann commented Aug 31, 2022
View reviewed changes
Comment thread content/tutorials/getting-started/go.md Outdated
salmad3
salmad3 reviewed Sep 1, 2022
View reviewed changes
Comment thread content/tutorials/getting-started/go.md Outdated
@salmad3 salmad3 removed the change request PR requires changes. label Sep 1, 2022
@netlify
Copy link
Copy Markdown

netlify Bot commented Sep 1, 2022 •
edited
Loading

✅ Deploy Preview for libp2p-docs-mirror ready!

Name Link
🔨 Latest commit 78ab579
🔍 Latest deploy log https://app.netlify.com/sites/libp2p-docs-mirror/deploys/631031e6ee9d7100097285e4
😎 Deploy Preview https://deploy-preview-121--libp2p-docs-mirror.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

marten-seemann
marten-seemann commented Sep 1, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor Author

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can't approve, since I'm the original author of this PR.

@salmad3 salmad3 removed the ready for review PR is ready for review label Sep 1, 2022
@salmad3 salmad3 merged commit 1bedc23 into master Sep 1, 2022
@salmad3 salmad3 deleted the go-116 branch September 7, 2022 02:39
@salmad3 salmad3 restored the go-116 branch September 7, 2022 02:39
@salmad3 salmad3 deleted the go-116 branch September 7, 2022 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@salmad3 salmad3 salmad3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

go-libp2p
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Update Go version to 1.18 or 1.19

4 participants

@marten-seemann @BigLep @MarcoPolo @salmad3